reinstate test

Author: agila5

R/vectortranslate.R

@@ -536,8 +536,11 @@ process_boundary = function(
   boundary = NULL,
   boundary_type = c("spat", "clipsrc")
 ) {
-  # Starting from #313, boundary might be NA on purpose
-  if (is.na(boundary) || is.null(boundary)) {
+  # Starting from #313, boundary might be NA on purpose.
+  # FIXME: How to handle the case where, for whatever reason, boundary is like
+  # c(NA, valid_polygon)? For the moment I'll just bypass this situation and
+  # ignore any boundary arg which contains at least one NA.
+  if (anyNA(boundary) || is.null(boundary)) {
     return(vectortranslate_options)
   }
 
@@ -563,7 +566,7 @@ process_boundary = function(
   # Check the number of geometries
   if (length(boundary) > 1L) {
     warning(
-      "The boundary is composed by more than one features. Selecting the first. ",
+      "The boundary is composed by more than one feature. Selecting the first.",
       call. = FALSE
     )
     boundary = boundary[1L]

tests/testthat/test-read.R

@@ -234,18 +234,18 @@ test_that("we can combine boundary = ... with other vectortranslate arguments",
   expect_equal(nrow(its_clipsrc_small), sum(its_clipsrc[["highway"]] == "footway", na.rm = TRUE))
 })
 
-# test_that("get a warning for more than 1 polygon in boundary = ...", {
-#   withr::local_envvar(
-#     .new = list(
-#       "OSMEXT_DOWNLOAD_DIRECTORY" = tempdir(),
-#       "TESTTHAT" = "true"
-#     )
-#   )
-#   its_pbf = setup_pbf()
-#
-#   # Warning for more than 1 POLYGON
-#   expect_warning(oe_read(its_pbf, boundary = c(its_poly, its_poly), quiet = TRUE))
-# })
+test_that("get warning for more than 1 polygon in boundary = ...", {
+  withr::local_envvar(
+    .new = list(
+      "OSMEXT_DOWNLOAD_DIRECTORY" = tempdir(),
+      "TESTTHAT" = "true"
+    )
+  )
+  its_pbf = setup_pbf()
+
+  # Warning for more than 1 POLYGON
+  expect_warning(oe_read(its_pbf, boundary = c(its_poly, its_poly), quiet = TRUE))
+})
 
 test_that("get error when boundary is not a POLYGON/MULTIPOLYGON", {
   withr::local_envvar(