Update route.R to add wt_profile parameter passthrough to route_dodgr… #573
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… route_fun Added wt_profile passthrough so that dodgr is able to accept other values for wt_profile to override the default "bicycle" value for wt_profile.
Robinlovelace
approved these changes
Apr 17, 2025
Contributor
Author
|
It seems like roxygen needs to be rerun to match up the man pages to the functions, but I don't have a local environment set up to do that. I'm working on getting situated so I can run roxygenize() on my local machine to match up the man pages. Once that's done, it should be good to merge. |
Contributor
Author
|
It's passing the ubuntu checks, so I am confident I at least haven't broken anything inadvertently. I'm good to merge. |
Member
|
Great job, please put the word out there if you get a chance, very happy about this! |
Contributor
Author
|
Great! Thanks, I'm glad it worked out! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… route_fun
Added wt_profile passthrough so that dodgr is able to accept other values for wt_profile to override the default "bicycle" value for wt_profile.