Commit f7b9edf
committed
fix(log): gate packet hexdumps off + grow the log-processing stack
The net image stack-overflowed the log thread at network-up: formatting a queued
message on the deferred log-processing thread (or, in immediate mode, the
emitting SMP/UDP transport thread) exceeded its ~1 KB stack and faulted the
system, so the node joined WiFi, got an IP, then died before it was reachable.
The deepest formatter is the full-packet hex dump (up to ~256 bytes) logged on
every TX and RX. Turn it off by default (MESHTASTIC_PACKET_HEXDUMP default n, was
on whenever the log level was DBG) and document the stack-overflow risk on the
Kconfig and at both call sites. Also give the log-processing thread modest
headroom (CONFIG_LOG_PROCESS_THREAD_STACK_SIZE=2048, was the ~1 KB default).
Verified on a Heltec V3: the net-ota image now boots, joins WiFi, and is
reachable over SMP + telnet with no fault.1 parent 4153341 commit f7b9edf
4 files changed
Lines changed: 23 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
9 | 9 | | |
10 | 10 | | |
11 | 11 | | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
12 | 16 | | |
13 | 17 | | |
14 | 18 | | |
15 | 19 | | |
16 | 20 | | |
17 | 21 | | |
18 | | - | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
19 | 26 | | |
20 | 27 | | |
21 | 28 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
67 | 67 | | |
68 | 68 | | |
69 | 69 | | |
70 | | - | |
| 70 | + | |
71 | 71 | | |
72 | 72 | | |
73 | 73 | | |
74 | 74 | | |
75 | 75 | | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
76 | 86 | | |
77 | 87 | | |
78 | 88 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
154 | 154 | | |
155 | 155 | | |
156 | 156 | | |
| 157 | + | |
| 158 | + | |
157 | 159 | | |
158 | 160 | | |
159 | 161 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
210 | 210 | | |
211 | 211 | | |
212 | 212 | | |
| 213 | + | |
| 214 | + | |
213 | 215 | | |
214 | 216 | | |
215 | 217 | | |
| |||
0 commit comments