forked from rjmurillo/EffectiveCSharp.Analyzers
-
Notifications
You must be signed in to change notification settings - Fork 0
/
Copy pathPreferDeclarationInitializersToAssignmentStatementsAnalyzer.cs
639 lines (563 loc) · 31.8 KB
/
PreferDeclarationInitializersToAssignmentStatementsAnalyzer.cs
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
namespace EffectiveCSharp.Analyzers;
/// <summary>
/// A <see cref="DiagnosticAnalyzer" /> for Effective C# Item #12 - Prefer field declaration initializers.
/// </summary>
/// <seealso cref="DiagnosticAnalyzer" />
[DiagnosticAnalyzer(LanguageNames.CSharp)]
public class PreferDeclarationInitializersToAssignmentStatementsAnalyzer : DiagnosticAnalyzer
{
private static readonly string HelpLinkUri = $"https://github.com/rjmurillo/EffectiveCSharp.Analyzers/blob/{ThisAssembly.GitCommitId}/docs/rules/{DiagnosticIds.PreferDeclarationInitializersToAssignmentStatement}.md";
private static readonly DiagnosticDescriptor GeneralRule = new(
id: DiagnosticIds.PreferDeclarationInitializersToAssignmentStatement,
title: "Prefer field declaration initializers to assignment statements",
messageFormat: "Use a field declaration initializer instead of an assignment statement",
category: "Maintainability",
defaultSeverity: DiagnosticSeverity.Info,
isEnabledByDefault: true,
description: "Field initialization in a constructor that does not use an argument should be done with a field declaration initializer.",
helpLinkUri: HelpLinkUri);
private static readonly DiagnosticDescriptor RuleExceptionShouldNotInitializeToNullOrZero = new(
id: DiagnosticIds.PreferDeclarationInitializersExceptNullOrZero,
title: "Should not initialize to null or zero",
messageFormat: "Do not initialize to null or zero as these already occur by default",
category: "Maintainability",
defaultSeverity: DiagnosticSeverity.Info,
isEnabledByDefault: true,
description: "Field initialization to null or zero is redundant and should be avoided.",
helpLinkUri: HelpLinkUri);
private static readonly DiagnosticDescriptor RuleExceptionShouldNotInitializeInDeclaration = new(
id: DiagnosticIds.PreferDeclarationInitializersExceptWhenVaryingInitializations,
title: "Should not initialize in declaration due to diverging initializations in constructors",
messageFormat: "Do not initialize a field in its declaration if you have diverging initializations in constructors. This is to prevent unnecessary allocations.",
category: "Maintainability",
defaultSeverity: DiagnosticSeverity.Info,
isEnabledByDefault: true,
description: "Field initialization should not occur when there are diverging initializations in constructors. This is to prevent unnecessary allocations.",
helpLinkUri: HelpLinkUri);
private static readonly DiagnosticDescriptor RuleShouldInitializeInDeclarationWhenNoInitializationPresent = new(
id: DiagnosticIds.PreferDeclarationInitializersWhenNoInitializationPresent,
title: "Should initialize in declaration when no initialization present",
messageFormat: "Initialize the field in its declaration when no distinct initializations will occur in constructors",
category: "Maintainability",
defaultSeverity: DiagnosticSeverity.Info,
isEnabledByDefault: true,
description: "Field initialization should occur in the declaration unless there are diverging initializations in constructors, or the field is a value type or nullable being initialized to the default.",
helpLinkUri: HelpLinkUri);
/// <inheritdoc />
public override ImmutableArray<DiagnosticDescriptor> SupportedDiagnostics => ImmutableArray.Create(GeneralRule, RuleExceptionShouldNotInitializeToNullOrZero, RuleExceptionShouldNotInitializeInDeclaration, RuleShouldInitializeInDeclarationWhenNoInitializationPresent);
/// <inheritdoc />
public override void Initialize(AnalysisContext context)
{
context.ConfigureGeneratedCodeAnalysis(GeneratedCodeAnalysisFlags.None);
context.EnableConcurrentExecution();
context.RegisterSyntaxNodeAction(AnalyzeNode, SyntaxKind.ClassDeclaration);
}
private static void AnalyzeNode(SyntaxNodeAnalysisContext context)
{
ClassDeclarationSyntax classSyntaxNode = (ClassDeclarationSyntax)context.Node;
// In order to keep track of the fields that are initialized in the constructors
// We create this dictionary that will track a field's initialization in the constructors.
// To save on time and memory, we only track fields that are initialized in the constructors.
Dictionary<string, FieldInitializationInfo> fieldInitializationInfo = new(5, StringComparer.Ordinal);
IEnumerable<SyntaxNode> childNodes = classSyntaxNode.ChildNodes();
List<FieldDeclarationSyntax> fields = new(5);
// Check in every constructor if there are field initializer candidates
foreach (SyntaxNode node in childNodes)
{
switch (node)
{
case ConstructorDeclarationSyntax constructor:
IEnumerable<SyntaxNode>? nodes = constructor.Body?.ChildNodes();
if (nodes is null)
{
continue;
}
bool isConstructorParameterless = constructor.ParameterList.Parameters.Count == 0;
FindFieldInitializerCandidatesInScope(context, nodes, fieldInitializationInfo, isConstructorParameterless);
break;
case PropertyDeclarationSyntax propertyDeclarationSyntax:
FindFieldInitializerCandidatesInPropertyDeclaration(propertyDeclarationSyntax, fieldInitializationInfo);
break;
case FieldDeclarationSyntax fieldDeclarationSyntax:
bool isConst = false;
for (int i = 0; i < fieldDeclarationSyntax.Modifiers.Count; ++i)
{
SyntaxKind kind = fieldDeclarationSyntax.Modifiers[i].Kind();
if (kind is not SyntaxKind.ConstKeyword)
{
continue;
}
// We only care about instance fields.
isConst = true;
break;
}
if (!isConst)
{
fields.Add(fieldDeclarationSyntax);
}
break;
}
}
// Report diagnostics on field declarations
ReportDiagnosticsOnFieldDeclarations(context, fields, fieldInitializationInfo);
}
/// <summary>
/// This method finds field initializer candidates in property declarations.
/// This should not be as common as in constructors, but it is still a valid scenario.
/// </summary>
/// <param name="propertyDeclaration">The property declaration syntax to analyze.</param>
/// <param name="fields">A dictionary tracking all fields initializations in constructors.</param>
private static void FindFieldInitializerCandidatesInPropertyDeclaration(PropertyDeclarationSyntax propertyDeclaration, Dictionary<string, FieldInitializationInfo> fields)
{
SyntaxList<AccessorDeclarationSyntax>? accessors = propertyDeclaration.AccessorList?.Accessors;
if (accessors is null)
{
return;
}
AccessorDeclarationSyntax? setter = null;
for (int i = 0; i < accessors.Value.Count; ++i)
{
if (accessors.Value[i].Kind() != SyntaxKind.SetAccessorDeclaration)
{
continue;
}
setter = accessors.Value[i];
break;
}
if (setter?.ExpressionBody?.Expression is not AssignmentExpressionSyntax { Left: IdentifierNameSyntax identifierNameSyntax })
{
return;
}
string fieldName = identifierNameSyntax.Identifier.Text;
if (!fields.TryGetValue(fieldName, out FieldInitializationInfo fieldInfo))
{
fieldInfo = new FieldInitializationInfo();
fields.Add(fieldName, fieldInfo);
}
// We assume hat if you use a field in a setter, you are initializing it in some form,
// and therefore we should initialize in the declaration.
fieldInfo.ShouldNotInitializeInDeclaration = true;
}
/// <summary>
/// This method finds every instance of a field being initialized in a constructor.
/// The initialization and some other information is then tracked via a <see cref="FieldInitializationInfo"/>.
/// </summary>
/// <param name="context">The node analysis context.</param>
/// <param name="nodes">The nodes to analyze for field initializer candidates.</param>
/// <param name="fields">A dictionary tracking all fields initialization in constructors.</param>
/// <param name="isConstructorParameterless">A bool on whether the constructor has parameters.</param>
/// <param name="isScopeConstructor">A bool on whether the scope the expressions are in is a constructor or some scope within the constructor, such as an if statement.</param>
private static void FindFieldInitializerCandidatesInScope(SyntaxNodeAnalysisContext context, IEnumerable<SyntaxNode> nodes, Dictionary<string, FieldInitializationInfo> fields, bool isConstructorParameterless, bool isScopeConstructor = true)
{
foreach (SyntaxNode node in nodes)
{
switch (node)
{
case IfStatementSyntax ifStatementSyntax:
FindFieldInitializerCandidatesInScope(context, ifStatementSyntax.Statement.ChildNodes(), fields, isConstructorParameterless, false);
if (ifStatementSyntax.Else is not null)
{
FindFieldInitializerCandidatesInScope(context, ifStatementSyntax.Else.ChildNodes(), fields, isConstructorParameterless, false);
}
break;
case ExpressionStatementSyntax expressionSyntax:
if (expressionSyntax.Expression is AssignmentExpressionSyntax assignment)
{
HandleConstructorExpressions(expressionSyntax, assignment, context, fields, isConstructorParameterless, isScopeConstructor);
}
else if (expressionSyntax.Expression is InvocationExpressionSyntax invocationExpressionSyntax)
{
HandleInvocation(invocationExpressionSyntax, context, fields, isConstructorParameterless);
}
break;
}
}
}
/// <summary>
/// This method handles an expression in a constructor to find field initializer candidates.
/// </summary>
/// <param name="expressionStatementSyntax">The expression where the candidate assignment was found.</param>
/// <param name="assignment">The assignment to check if for field initializations.</param>
/// <param name="context">The node analysis context.</param>
/// <param name="fields">A dictionary tracking all fields initializations in constructors.</param>
/// <param name="isConstructorParameterless">A bool on whether the constructor has parameters.</param>
/// <param name="isScopeConstructor">A bool on whether the scope the expressions are in is a constructor or some scope within the constructor, such as an if statement.</param>
private static void HandleConstructorExpressions(
ExpressionStatementSyntax expressionStatementSyntax,
AssignmentExpressionSyntax assignment,
SyntaxNodeAnalysisContext context,
Dictionary<string, FieldInitializationInfo> fields,
bool isConstructorParameterless,
bool isScopeConstructor)
{
IdentifierNameSyntax? identifierName = assignment.Left switch
{
IdentifierNameSyntax idName => idName,
MemberAccessExpressionSyntax { Name: IdentifierNameSyntax idName } => idName,
_ => null,
};
if (identifierName is null)
{
return;
}
// We assume the identifier is a field.
// Calls to semantic model are super expensive, so we want to avoid them as much as possible.
string fieldName = identifierName.Identifier.Text;
if (!fields.TryGetValue(fieldName, out FieldInitializationInfo fieldInfo))
{
fieldInfo = new FieldInitializationInfo();
fields.Add(fieldName, fieldInfo);
}
else if (fieldInfo.ShouldNotInitializeInDeclaration)
{
return;
}
if (!isScopeConstructor)
{
fieldInfo.ShouldNotInitializeInDeclaration = true;
return;
}
ExpressionSyntax rightSide = assignment.Right;
if ((isConstructorParameterless && rightSide is IdentifierNameSyntax)
|| rightSide is LiteralExpressionSyntax
|| rightSide is MemberAccessExpressionSyntax { Expression: PredefinedTypeSyntax })
{
ProcessFieldInitializerCandidate(
assignment,
expressionStatementSyntax,
fieldInfo);
}
else if (rightSide is IdentifierNameSyntax
|| !IsExpressionValidDeclarationInitialization(rightSide, context, isConstructorParameterless))
{
fieldInfo.ShouldNotInitializeInDeclaration = true;
}
else
{
ProcessFieldInitializerCandidate(
assignment,
expressionStatementSyntax,
fieldInfo);
}
}
/// <summary>
/// Checks whether the constructor parameter is in use in the expression.
/// </summary>
/// <param name="expression">The expression to evaluate.</param>
/// <param name="context">The analysis context.</param>
/// <param name="isConstructorParameterLess">A bool on whether the constructor has parameters.</param>
/// <returns>A bool, on whether we've found a constructor parameter in use.</returns>
private static bool IsExpressionValidDeclarationInitialization(ExpressionSyntax expression, SyntaxNodeAnalysisContext context, bool isConstructorParameterLess)
{
return expression switch
{
// There are many ways of initializing the same field, so we need to check many different types of expressions.
// For example, new List<string>() == [] == new List<string> { }. So we need to consider these scenarios.
LiteralExpressionSyntax => true,
IdentifierNameSyntax => isConstructorParameterLess,
InvocationExpressionSyntax invocationExpressionSyntax => IsExpressionValidDeclarationInitialization(invocationExpressionSyntax, context, isConstructorParameterLess),
ObjectCreationExpressionSyntax objectCreationExpressionSyntax => IsExpressionValidDeclarationInitialization(objectCreationExpressionSyntax.ArgumentList, context, isConstructorParameterLess),
ImplicitObjectCreationExpressionSyntax implicitObjectCreationExpressionSyntax => IsExpressionValidDeclarationInitialization(implicitObjectCreationExpressionSyntax.ArgumentList, context, isConstructorParameterLess),
InitializerExpressionSyntax initializerExpressionSyntax => IsExpressionValidDeclarationInitialization(initializerExpressionSyntax.Expressions, context, isConstructorParameterLess),
BinaryExpressionSyntax binaryExpressionSyntax => IsExpressionValidDeclarationInitialization(binaryExpressionSyntax.Left, context, isConstructorParameterLess) && IsExpressionValidDeclarationInitialization(binaryExpressionSyntax.Right, context, isConstructorParameterLess),
_ => false,
};
}
private static bool IsExpressionValidDeclarationInitialization(InvocationExpressionSyntax invocation, SyntaxNodeAnalysisContext context, bool isConstructorParameterless)
{
return isConstructorParameterless && IsExpressionValidDeclarationInitialization(invocation.ArgumentList, context, isConstructorParameterless) &&
IsStaticMethodInvocation(invocation, context);
}
// Overload for SyntaxNode
private static bool IsExpressionValidDeclarationInitialization(ArgumentListSyntax? argumentList, SyntaxNodeAnalysisContext context, bool isConstructorParameterless)
{
if (argumentList is null)
{
return false;
}
foreach (SyntaxNode node in argumentList.ChildNodes())
{
if (node is not ArgumentSyntax argument)
{
continue;
}
if (argument.Expression is IdentifierNameSyntax
|| !IsExpressionValidDeclarationInitialization(argument.Expression, context, isConstructorParameterless))
{
return false;
}
}
return true;
}
// Overload for SeparatedSyntaxList<ExpressionSyntax>
private static bool IsExpressionValidDeclarationInitialization(SeparatedSyntaxList<ExpressionSyntax> expressions, SyntaxNodeAnalysisContext context, bool isConstructorParameterLess)
{
foreach (ExpressionSyntax expression in expressions)
{
if (!IsExpressionValidDeclarationInitialization(expression, context, isConstructorParameterLess))
{
return false;
}
}
return true;
}
/// <summary>
/// Checks whether the invocation expression is a static method invocation.
/// </summary>
/// <param name="invocationExpression">The target <see cref="InvocationExpressionSyntax"/>.</param>
/// <param name="context">The <see cref="SyntaxNodeAnalysisContext"/>.</param>
/// <returns>A bool on whether the invocation is for a static method.</returns>
private static bool IsStaticMethodInvocation(InvocationExpressionSyntax invocationExpression, SyntaxNodeAnalysisContext context)
{
// Get the symbol information for the method being invoked
IMethodSymbol? methodSymbol = (IMethodSymbol?)context.SemanticModel.GetSymbolInfo(invocationExpression, context.CancellationToken).Symbol;
// Check if the method symbol is not null and is not static
return methodSymbol?.IsStatic is true;
}
/// <summary>
/// Processes a field initializer candidate.
/// If the initialization is not being tracked or is identical to the first tracked initialization,
/// it is added to the list of initializers.
/// Else, the field is marked as not to be initialized in the declaration since there are diverging initializations.
/// </summary>
/// <param name="assignment">The assignment node to check for equivalence.</param>
/// <param name="expressionStatement">The expression statement to cache if needed.</param>
/// <param name="fieldInitializationInfo">The field initialization info object tracking the field's initializers' state.</param>
private static void ProcessFieldInitializerCandidate(
AssignmentExpressionSyntax assignment,
ExpressionStatementSyntax expressionStatement,
FieldInitializationInfo fieldInitializationInfo)
{
List<ExpressionStatementSyntax> fieldInitializersInConstructors = fieldInitializationInfo.FieldInitializersInConstructors;
if (fieldInitializersInConstructors.Count == 0)
{
fieldInitializersInConstructors.Add(expressionStatement);
}
else if (((AssignmentExpressionSyntax)fieldInitializersInConstructors[0].Expression).Right.IsEquivalentTo(assignment.Right))
{
fieldInitializersInConstructors.Add(expressionStatement);
}
else
{
fieldInitializationInfo.ShouldNotInitializeInDeclaration = true;
}
}
/// <summary>
/// This method handles invocations in constructors that are not part of an assignment expression.
/// </summary>
/// <param name="invocation">The invocation expression to check for field initialization candidates.</param>
/// <param name="context">The node analysis context.</param>
/// <param name="fields">A dictionary tracking all fields initialization in constructors.</param>
/// <param name="isConstructorParameterless">A bool on whether the constructor has parameters.</param>
private static void HandleInvocation(InvocationExpressionSyntax invocation, SyntaxNodeAnalysisContext context, Dictionary<string, FieldInitializationInfo> fields, bool isConstructorParameterless)
{
if (context.SemanticModel.GetSymbolInfo(invocation, context.CancellationToken).Symbol is not IMethodSymbol methodSymbol
|| methodSymbol.DeclaringSyntaxReferences.FirstOrDefault()?.GetSyntax(context.CancellationToken) is not MethodDeclarationSyntax methodDeclaration
|| methodDeclaration.Body is null)
{
return;
}
FindFieldInitializerCandidatesInScope(context, methodDeclaration.Body.ChildNodes(), fields, isConstructorParameterless, isScopeConstructor: false);
}
/// <summary>
/// Reports diagnostics on field declarations.
/// </summary>
/// <param name="context">The analysis context.</param>
/// <param name="classDeclarationChildNodes">The class declaration child nodes to iterate through.</param>
/// <param name="fieldInitializationInfos">The initialization info for all fields present in a constructor.</param>
private static void ReportDiagnosticsOnFieldDeclarations(SyntaxNodeAnalysisContext context, List<FieldDeclarationSyntax> classDeclarationChildNodes, Dictionary<string, FieldInitializationInfo> fieldInitializationInfos)
{
for (int i = 0; i < classDeclarationChildNodes.Count; ++i)
{
FieldDeclarationSyntax field = classDeclarationChildNodes[i];
SeparatedSyntaxList<VariableDeclaratorSyntax> variables = field.Declaration.Variables;
if (variables.Count != 1)
{
// We only support single variable declarations for now.
continue;
}
VariableDeclaratorSyntax variable = variables[0];
EqualsValueClauseSyntax? initializer = variable.Initializer;
if (!fieldInitializationInfos.TryGetValue(variable.Identifier.Text, out FieldInitializationInfo fieldInfo))
{
// Field was not found in constructors.
HandleFieldNotInConstructors(context, field, variable, initializer);
}
else
{
// Field was found in constructors.
HandleFieldsInConstructors(context, field, fieldInfo, initializer);
}
}
}
/// <summary>
/// Handles fields that are not initialized in constructors.
/// If the initializer is present, and the field is a value type that is initialized to null, zero, false or an empty struct,
/// a diagnostic is reported to remove the initialization in the declaration.
/// If the initializer is not present, and the field is not a value type or nullable, a diagnostic is reported to
/// initialize in declaration.
/// </summary>
/// <param name="context">The analysis context.</param>
/// <param name="field">The field declaration to analyze.</param>
/// <param name="variable">The variable declarator node.</param>
/// <param name="initializer">The field initializer.</param>
private static void HandleFieldNotInConstructors(
SyntaxNodeAnalysisContext context,
FieldDeclarationSyntax field,
VariableDeclaratorSyntax variable,
EqualsValueClauseSyntax? initializer)
{
if (initializer is not null)
{
if (IsFieldNullZeroOrFalseWithInitializer(context, initializer)
|| IsStructInitializerEmpty(context, field.Declaration.Type, initializer))
{
// If the initializer is present, and the field is a value type that is initialized to null, zero, false or an empty struct,
// a diagnostic is reported to remove the initialization in the declaration.
context.ReportDiagnostic(field.GetLocation().CreateDiagnostic(RuleExceptionShouldNotInitializeToNullOrZero));
}
}
else
{
if (context.SemanticModel.GetDeclaredSymbol(variable, cancellationToken: context.CancellationToken) is IFieldSymbol fieldSymbol
&& !CanTypeInitializeToZeroOrNull(fieldSymbol))
{
// If the initializer is not present, and the field is not a value type or nullable, a diagnostic is reported to
// initialize in declaration.
context.ReportDiagnostic(field.GetLocation()
.CreateDiagnostic(RuleShouldInitializeInDeclarationWhenNoInitializationPresent));
}
}
}
/// <summary>
/// Determines whether the field is initialized to null, zero or false.
/// </summary>
/// <param name="context">The analysis context.</param>
/// <param name="initializer">The initializer node to check.</param>
/// <returns>A bool on whether the field was initialized to null, zero or false.</returns>
private static bool IsFieldNullZeroOrFalseWithInitializer(SyntaxNodeAnalysisContext context, EqualsValueClauseSyntax initializer)
{
SyntaxKind initializerKind = initializer.Value.Kind();
switch (initializerKind)
{
case SyntaxKind.NullLiteralExpression:
// To avoid calling the semantic model, we simply check if the value text is "null".
return string.Equals(((LiteralExpressionSyntax)initializer.Value).Token.ValueText, "null", StringComparison.Ordinal);
case SyntaxKind.NumericLiteralExpression:
{
// There are many ways of initializing to zero (0, 0d, 0f, etc.), so we use the semantic model to check the constant value
// since that is 0 regardless of the syntax used.
Optional<object?> constantValue = context.SemanticModel.GetConstantValue(initializer.Value, context.CancellationToken);
return constantValue is { HasValue: true, Value: int and 0 };
}
default:
// We check if the initializer is a false literal expression.
return initializerKind == SyntaxKind.FalseLiteralExpression;
}
}
/// <summary>
/// Determines whether the struct initializer is empty.
/// </summary>
/// <param name="context">The analysis context.</param>
/// <param name="typeSyntax">The type node of the field.</param>
/// <param name="initializer">The initializer node to check.</param>
/// <returns>A bool on whether the struct initializer is empty.</returns>
private static bool IsStructInitializerEmpty(SyntaxNodeAnalysisContext context, TypeSyntax typeSyntax, EqualsValueClauseSyntax initializer)
{
TypeInfo symbol = context.SemanticModel.GetTypeInfo(typeSyntax, context.CancellationToken);
// if the type is not a struct or the initializer is not an object creation (meaning the struct is being initialized)
// we return false.
if (symbol.Type?.TypeKind != TypeKind.Struct
|| initializer.Value is not ObjectCreationExpressionSyntax objectCreation)
{
return false;
}
// If the object creation has no arguments, we consider it an empty struct initializer.
return objectCreation.ArgumentList?.Arguments.Count == 0;
}
/// <summary>
/// Determines whether the field is a type that can be initialized to zero or null.
/// </summary>
/// <param name="fieldSymbol">The field symbol information to check.</param>
/// <returns>A bool, on whether the field is a type that can be initialized to null or 0.</returns>
private static bool CanTypeInitializeToZeroOrNull(IFieldSymbol fieldSymbol)
{
return fieldSymbol.Type.IsValueType || fieldSymbol.NullableAnnotation == NullableAnnotation.Annotated;
}
/// <summary>
/// Handles fields that are initialized in constructors.
/// </summary>
/// <param name="context">The <see cref="SyntaxNodeAnalysisContext"/>.</param>
/// <param name="field">The <see cref="FieldDeclarationSyntax"/> to handle.</param>
/// <param name="fieldInfo">The field's initialization info found in the class's constructors.</param>
/// <param name="initializer">The <see cref="EqualsValueClauseSyntax"/> which contains the field initializer.</param>
private static void HandleFieldsInConstructors(
SyntaxNodeAnalysisContext context,
FieldDeclarationSyntax field,
FieldInitializationInfo fieldInfo,
EqualsValueClauseSyntax? initializer)
{
if (fieldInfo.ShouldNotInitializeInDeclaration)
{
if (initializer is not null)
{
// The field was marked as not to initialize in the declaration due to diverging initializations in constructors.
// and an initializer is present, meaning we report a diagnostic.
context.ReportDiagnostic(field.GetLocation().CreateDiagnostic(RuleExceptionShouldNotInitializeInDeclaration));
}
return;
}
List<ExpressionStatementSyntax> fieldInitializersInConstructors = fieldInfo.FieldInitializersInConstructors;
// If the field is initialized in the declaration and in the constructors,
// we check if the initializations are diverging.
// Since we already checked if the field should not initialize in the declaration,
// we know all initializations in the constructors are the same.
// So we only need to check if the initializer is diverging from the constructor initializations.
if (initializer is not null
&& fieldInitializersInConstructors.Count != 0
&& HasDivergingInitializations(fieldInitializersInConstructors[0], initializer))
{
context.ReportDiagnostic(field.GetLocation().CreateDiagnostic(RuleExceptionShouldNotInitializeInDeclaration));
return;
}
// We know the initializers in the constructors are the same, so we report diagnostics (general rule) on them.
ReportDiagnosticsForInitializersInConstructors(context, fieldInitializersInConstructors);
}
/// <summary>
/// Checks if the initializers in the constructors are diverging from the initializer in the declaration.
/// </summary>
/// <param name="initializerInConstructor">A <see cref="ExpressionStatementSyntax"/> from the constructor.</param>
/// <param name="initializerInDeclaration">The initializer from the declaration.</param>
/// <returns>A bool on whether the constructor initializers diverge from the declaration.</returns>
private static bool HasDivergingInitializations(ExpressionStatementSyntax initializerInConstructor, EqualsValueClauseSyntax initializerInDeclaration)
{
return !((AssignmentExpressionSyntax)initializerInConstructor.Expression).Right.IsEquivalentTo(initializerInDeclaration.Value);
}
/// <summary>
/// Reports diagnostics for initializers in constructors <see cref="GeneralRule"/>.
/// </summary>
/// <param name="context">The analysis context.</param>
/// <param name="initializers">The list of constructor field initializers.</param>
private static void ReportDiagnosticsForInitializersInConstructors(SyntaxNodeAnalysisContext context, List<ExpressionStatementSyntax> initializers)
{
for (int i = 0; i < initializers.Count; i++)
{
AssignmentExpressionSyntax assignment = (AssignmentExpressionSyntax)initializers[i].Expression;
context.ReportDiagnostic(assignment.Right.GetLocation().CreateDiagnostic(GeneralRule));
}
}
/// <summary>
/// A record to track field initialization information in constructors.
/// </summary>
private sealed class FieldInitializationInfo
{
/// <summary>
/// Gets the field initializers in constructors.
/// </summary>
public List<ExpressionStatementSyntax> FieldInitializersInConstructors { get; } = new(3);
/// <summary>
/// Gets or sets a value indicating whether the field should not initialize in the declaration.
/// </summary>
public bool ShouldNotInitializeInDeclaration { get; set; }
}
}