Skip to content

Commit 91cce17

Browse files
committed
Rename the mutexes prefixing prio_inherit_
1 parent 07e4e3a commit 91cce17

File tree

2 files changed

+33
-36
lines changed

2 files changed

+33
-36
lines changed

include/realtime_tools/mutex.hpp

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -34,8 +34,6 @@
3434
*/
3535
namespace realtime_tools
3636
{
37-
namespace priority_inheritance
38-
{
3937
namespace detail
4038
{
4139
/**
@@ -170,9 +168,8 @@ class mutex
170168
pthread_mutex_t mutex_;
171169
};
172170
} // namespace detail
173-
using mutex = detail::mutex<PTHREAD_MUTEX_ERRORCHECK, PTHREAD_MUTEX_ROBUST>;
174-
using recursive_mutex = detail::mutex<PTHREAD_MUTEX_RECURSIVE, PTHREAD_MUTEX_ROBUST>;
175-
} // namespace priority_inheritance
171+
using prio_inherit_mutex = detail::mutex<PTHREAD_MUTEX_ERRORCHECK, PTHREAD_MUTEX_ROBUST>;
172+
using prio_inherit_recursive_mutex = detail::mutex<PTHREAD_MUTEX_RECURSIVE, PTHREAD_MUTEX_ROBUST>;
176173
} // namespace realtime_tools
177174

178175
#endif // REALTIME_TOOLS__MUTEX_HPP_

test/realtime_mutex_tests.cpp

Lines changed: 31 additions & 31 deletions
Original file line numberDiff line numberDiff line change
@@ -24,15 +24,15 @@
2424
TEST(PriorityInheritanceMutexTests, lock_unlock)
2525
{
2626
// The mutex is locked and unlocked correctly
27-
realtime_tools::priority_inheritance::mutex mutex;
27+
realtime_tools::prio_inherit_mutex mutex;
2828
mutex.lock();
2929
mutex.unlock();
3030
}
3131

3232
TEST(PriorityInheritanceMutexTests, lock_unlock_multithreaded)
3333
{
3434
// The mutex is locked and unlocked correctly in a multithreaded environment
35-
realtime_tools::priority_inheritance::mutex mutex;
35+
realtime_tools::prio_inherit_mutex mutex;
3636
std::thread t1([&mutex]() {
3737
mutex.lock();
3838
std::this_thread::sleep_for(std::chrono::milliseconds(100));
@@ -50,7 +50,7 @@ TEST(PriorityInheritanceMutexTests, lock_unlock_multithreaded)
5050
TEST(PriorityInheritanceMutexTests, recursive_lock_lock_unlock_multithreaded)
5151
{
5252
// The mutex is locked and unlocked correctly in a multithreaded environment
53-
realtime_tools::priority_inheritance::recursive_mutex mutex;
53+
realtime_tools::prio_inherit_recursive_mutex mutex;
5454
std::thread t1([&mutex]() {
5555
mutex.lock();
5656
std::this_thread::sleep_for(std::chrono::milliseconds(100));
@@ -72,8 +72,8 @@ TEST(PriorityInheritanceMutexTests, recursive_lock_lock_unlock_multithreaded)
7272
TEST(PriorityInheritanceMutexTests, lock_unlock_multithreaded_multiple_mutexes)
7373
{
7474
// The mutex is locked and unlocked correctly in a multithreaded environment with multiple mutexes
75-
realtime_tools::priority_inheritance::mutex mutex1;
76-
realtime_tools::priority_inheritance::mutex mutex2;
75+
realtime_tools::prio_inherit_mutex mutex1;
76+
realtime_tools::prio_inherit_mutex mutex2;
7777
std::thread t1([&mutex1, &mutex2]() {
7878
mutex1.lock();
7979
std::this_thread::sleep_for(std::chrono::milliseconds(100));
@@ -97,8 +97,8 @@ TEST(PriorityInheritanceMutexTests, lock_unlock_multithreaded_multiple_mutexes)
9797
TEST(PriorityInheritanceMutexTests, lock_unlock_multithreaded_multiple_mutexes_different_types)
9898
{
9999
// The mutex is locked and unlocked correctly in a multithreaded environment with multiple mutexes
100-
realtime_tools::priority_inheritance::mutex mutex1;
101-
realtime_tools::priority_inheritance::recursive_mutex mutex2;
100+
realtime_tools::prio_inherit_mutex mutex1;
101+
realtime_tools::prio_inherit_recursive_mutex mutex2;
102102
std::thread t1([&mutex1, &mutex2]() {
103103
mutex1.lock();
104104
std::this_thread::sleep_for(std::chrono::milliseconds(100));
@@ -122,7 +122,7 @@ TEST(PriorityInheritanceMutexTests, lock_unlock_multithreaded_multiple_mutexes_d
122122
TEST(PriorityInheritanceMutexTests, lock_unlock_recursive_mutex)
123123
{
124124
// Test to check that the mutex is recursive
125-
realtime_tools::priority_inheritance::recursive_mutex mutex;
125+
realtime_tools::prio_inherit_recursive_mutex mutex;
126126
mutex.lock();
127127
mutex.lock();
128128
mutex.unlock();
@@ -131,8 +131,8 @@ TEST(PriorityInheritanceMutexTests, lock_unlock_recursive_mutex)
131131

132132
TEST(PriorityInheritanceMutexTests, lock_unlock_multithreaded_recursive_mutex_multiple_mutexes)
133133
{
134-
realtime_tools::priority_inheritance::recursive_mutex mutex1;
135-
realtime_tools::priority_inheritance::recursive_mutex mutex2;
134+
realtime_tools::prio_inherit_recursive_mutex mutex1;
135+
realtime_tools::prio_inherit_recursive_mutex mutex2;
136136
std::thread t1([&mutex1, &mutex2]() {
137137
mutex1.lock();
138138
std::this_thread::sleep_for(std::chrono::milliseconds(100));
@@ -155,7 +155,7 @@ TEST(PriorityInheritanceMutexTests, lock_unlock_multithreaded_recursive_mutex_mu
155155

156156
TEST(PriorityInheritanceMutexTests, lock_unlock_multithreaded_mutex_one_thread_dies)
157157
{
158-
realtime_tools::priority_inheritance::mutex mutex;
158+
realtime_tools::prio_inherit_mutex mutex;
159159
std::thread t1([&mutex]() {
160160
mutex.lock();
161161
std::this_thread::sleep_for(std::chrono::milliseconds(100));
@@ -174,7 +174,7 @@ TEST(PriorityInheritanceMutexTests, lock_unlock_multithreaded_mutex_one_thread_d
174174

175175
TEST(PriorityInheritanceMutexTests, lock_unlock_multithreaded_recursive_mutex_one_thread_dies)
176176
{
177-
realtime_tools::priority_inheritance::recursive_mutex mutex;
177+
realtime_tools::prio_inherit_recursive_mutex mutex;
178178
std::thread t1([&mutex]() {
179179
mutex.lock();
180180
std::this_thread::sleep_for(std::chrono::milliseconds(100));
@@ -193,34 +193,34 @@ TEST(PriorityInheritanceMutexTests, lock_unlock_multithreaded_recursive_mutex_on
193193

194194
TEST(PriorityInheritanceMutexTests, lock_guard_mutex)
195195
{
196-
realtime_tools::priority_inheritance::mutex mutex;
196+
realtime_tools::prio_inherit_mutex mutex;
197197
{
198-
std::lock_guard<realtime_tools::priority_inheritance::mutex> lock(mutex);
198+
std::lock_guard<realtime_tools::prio_inherit_mutex> lock(mutex);
199199
}
200200

201-
realtime_tools::priority_inheritance::recursive_mutex recursive_mutex;
201+
realtime_tools::prio_inherit_recursive_mutex recursive_mutex;
202202
{
203-
std::lock_guard<realtime_tools::priority_inheritance::recursive_mutex> lock(recursive_mutex);
203+
std::lock_guard<realtime_tools::prio_inherit_recursive_mutex> lock(recursive_mutex);
204204
}
205205
}
206206

207207
TEST(PriorityInheritanceMutexTests, unique_lock_mutex)
208208
{
209-
realtime_tools::priority_inheritance::mutex mutex;
209+
realtime_tools::prio_inherit_mutex mutex;
210210
{
211-
std::unique_lock<realtime_tools::priority_inheritance::mutex> lock(mutex);
211+
std::unique_lock<realtime_tools::prio_inherit_mutex> lock(mutex);
212212
}
213213

214-
realtime_tools::priority_inheritance::recursive_mutex recursive_mutex;
214+
realtime_tools::prio_inherit_recursive_mutex recursive_mutex;
215215
{
216-
std::unique_lock<realtime_tools::priority_inheritance::recursive_mutex> lock(recursive_mutex);
216+
std::unique_lock<realtime_tools::prio_inherit_recursive_mutex> lock(recursive_mutex);
217217
}
218218
}
219219

220220
TEST(PriorityInheritanceMutexTests, try_lock_mutex)
221221
{
222222
{
223-
realtime_tools::priority_inheritance::mutex mutex;
223+
realtime_tools::prio_inherit_mutex mutex;
224224
ASSERT_TRUE(mutex.try_lock());
225225
ASSERT_THROW(mutex.try_lock(), std::system_error)
226226
<< "Mutex is already locked in the same thread";
@@ -235,7 +235,7 @@ TEST(PriorityInheritanceMutexTests, try_lock_mutex)
235235
}
236236

237237
{
238-
realtime_tools::priority_inheritance::recursive_mutex recursive_mutex;
238+
realtime_tools::prio_inherit_recursive_mutex recursive_mutex;
239239
ASSERT_TRUE(recursive_mutex.try_lock());
240240
ASSERT_TRUE(recursive_mutex.try_lock());
241241
ASSERT_TRUE(recursive_mutex.try_lock());
@@ -247,8 +247,8 @@ TEST(PriorityInheritanceMutexTests, try_lock_mutex)
247247

248248
TEST(PriorityInheritanceMutexTests, standard_lock_test)
249249
{
250-
realtime_tools::priority_inheritance::mutex mutex1;
251-
realtime_tools::priority_inheritance::mutex mutex2;
250+
realtime_tools::prio_inherit_mutex mutex1;
251+
realtime_tools::prio_inherit_mutex mutex2;
252252
{
253253
std::lock(mutex1, mutex2);
254254
// do work
@@ -267,13 +267,13 @@ TEST(PriorityInheritanceMutexTests, standard_lock_test)
267267
TEST(PriorityInheritanceMutexTests, native_handle_mutex)
268268
{
269269
{
270-
realtime_tools::priority_inheritance::mutex mutex;
270+
realtime_tools::prio_inherit_mutex mutex;
271271
auto native_handle = mutex.native_handle();
272272
ASSERT_NE(native_handle, nullptr);
273273
}
274274

275275
{
276-
realtime_tools::priority_inheritance::recursive_mutex recursive_mutex;
276+
realtime_tools::prio_inherit_recursive_mutex recursive_mutex;
277277
auto native_handle = recursive_mutex.native_handle();
278278
ASSERT_NE(native_handle, nullptr);
279279
}
@@ -282,7 +282,7 @@ TEST(PriorityInheritanceMutexTests, native_handle_mutex)
282282
TEST(PriorityInheritanceMutexTests, test_mutex_lock_functionality)
283283
{
284284
// Trying to lock again should throw an exception
285-
realtime_tools::priority_inheritance::mutex mutex;
285+
realtime_tools::prio_inherit_mutex mutex;
286286
mutex.lock();
287287
ASSERT_THROW(mutex.lock(), std::system_error);
288288
mutex.unlock();
@@ -295,23 +295,23 @@ TEST(PriorityInheritanceMutexTests, test_mutex_lock_functionality)
295295

296296
TEST(PriorityInheritanceMutexTests, test_lock_constructors)
297297
{
298-
realtime_tools::priority_inheritance::mutex mutex;
298+
realtime_tools::prio_inherit_mutex mutex;
299299
{
300-
std::unique_lock<realtime_tools::priority_inheritance::mutex> lock(mutex, std::defer_lock);
300+
std::unique_lock<realtime_tools::prio_inherit_mutex> lock(mutex, std::defer_lock);
301301
ASSERT_FALSE(lock.owns_lock());
302302
lock.lock();
303303
ASSERT_TRUE(lock.owns_lock());
304304
lock.unlock();
305305
}
306306
{
307-
std::unique_lock<realtime_tools::priority_inheritance::mutex> lock(mutex, std::try_to_lock);
307+
std::unique_lock<realtime_tools::prio_inherit_mutex> lock(mutex, std::try_to_lock);
308308
ASSERT_TRUE(lock.owns_lock());
309309
}
310310
}
311311

312312
TEST(PriorityInheritanceMutexTests, test_deadlock_detection)
313313
{
314-
realtime_tools::priority_inheritance::mutex mutex;
314+
realtime_tools::prio_inherit_mutex mutex;
315315
mutex.lock();
316316
std::this_thread::sleep_for(std::chrono::milliseconds(100));
317317
ASSERT_THROW(mutex.try_lock(), std::system_error);

0 commit comments

Comments
 (0)