Skip to content

JTC test_scaling_execution_time_succeeds is flaky #2554

Description

@christophfroehlich

Describe the bug


2026-08-10T04:45:43.5820933Z     [  FAILED  ] ScaledJTCTests/TestTrajectoryActionsTestScalingFactor.test_scaling_execution_time_succeeds/3, where GetParam() = 2
2026-08-10T04:45:43.5821013Z     
2026-08-10T04:45:43.5821095Z      1 FAILED TEST
2026-08-10T04:45:43.5821221Z     -- run_test.py: return code 1
2026-08-10T04:45:43.5822109Z     -- run_test.py: inject classname prefix into gtest result file '/__w/ros2_controllers/ros2_controllers/ros_ws/build/joint_trajectory_controller/test_results/joint_trajectory_controller/test_trajectory_actions.gtest.xml'
2026-08-10T04:45:43.5822813Z     -- run_test.py: verify result file '/__w/ros2_controllers/ros2_controllers/ros_ws/build/joint_trajectory_controller/test_results/joint_trajectory_controller/test_trajectory_actions.gtest.xml'
2026-08-10T04:45:43.5822903Z   >>>
2026-08-10T04:45:43.5823541Z build/joint_trajectory_controller/test_results/joint_trajectory_controller/test_trajectory_actions.gtest.xml: 142 tests, 0 errors, 1 failure, 0 skipped
2026-08-10T04:45:43.5824746Z - joint_trajectory_controller.ScaledJTCTests/TestTrajectoryActionsTestScalingFactor test_scaling_execution_time_succeeds/3 (/__w/ros2_controllers/ros2_controllers/ros_ws/src/0vj6f1iotz8e/ros2_controllers/joint_trajectory_controller/test/test_trajectory_actions.cpp:1274)
2026-08-10T04:45:43.5824840Z   <<< failure message
2026-08-10T04:45:43.5825372Z     /__w/ros2_controllers/ros2_controllers/ros_ws/src/0vj6f1iotz8e/ros2_controllers/joint_trajectory_controller/test/test_trajectory_actions.cpp:1306
2026-08-10T04:45:43.5826310Z     The difference between time_diff_sec(feedback_msg->desired.time_from_start) and time_diff_sec(feedback_msg->actual.time_from_start) * scaling_factor is 6.4482000000004591e-05, which exceeds 1e-3 * time_diff_sec(feedback_msg->actual.time_from_start), where
2026-08-10T04:45:43.5826688Z     time_diff_sec(feedback_msg->desired.time_from_start) evaluates to 0.100629754,
2026-08-10T04:45:43.5827045Z     time_diff_sec(feedback_msg->actual.time_from_start) * scaling_factor evaluates to 0.10069423600000001, and
2026-08-10T04:45:43.5827359Z     1e-3 * time_diff_sec(feedback_msg->actual.time_from_start) evaluates to 5.0347118000000007e-05.
2026-08-10T04:45:43.5827441Z   >>>
     [  FAILED  ] ScaledJTCTests/TestTrajectoryActionsTestScalingFactor.test_scaling_execution_time_succeeds/0, where GetParam() = 0.25
    
     1 FAILED TEST
    -- run_test.py: return code 1
    -- run_test.py: inject classname prefix into gtest result file '/home/runner/work/ros2_controllers/ros2_controllers/.work/target_ws/build/joint_trajectory_controller/test_results/joint_trajectory_controller/test_trajectory_actions.gtest.xml'
    -- run_test.py: verify result file '/home/runner/work/ros2_controllers/ros2_controllers/.work/target_ws/build/joint_trajectory_controller/test_results/joint_trajectory_controller/test_trajectory_actions.gtest.xml'
  >>>
build/joint_trajectory_controller/test_results/joint_trajectory_controller/test_trajectory_actions.gtest.xml: 143 tests, 0 errors, 1 failure, 0 skipped
- joint_trajectory_controller.ScaledJTCTests/TestTrajectoryActionsTestScalingFactor test_scaling_execution_time_succeeds/0 (/home/runner/work/ros2_controllers/ros2_controllers/.work/target_ws/src/ros2_controllers/joint_trajectory_controller/test/test_trajectory_actions.cpp:1343)
  <<< failure message
    /home/runner/work/ros2_controllers/ros2_controllers/.work/target_ws/src/ros2_controllers/joint_trajectory_controller/test/test_trajectory_actions.cpp:1376
    Expected equality of these values:
      static_cast<int32_t>(expected_index)
        Which is: 0
      feedback_msg->index
        Which is: 1
  >>>

To Reproduce
#2549

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions