Skip to content

Commit 7c945c3

Browse files
replace removed 'settingsChanged' signal with 'addOnChanged'
1 parent 0fea0f8 commit 7c945c3

File tree

3 files changed

+9
-6
lines changed

3 files changed

+9
-6
lines changed

src/project_manager/ros_catkin_make_step.cpp

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,7 @@
3030
#include <projectexplorer/processparameters.h>
3131
#include <projectexplorer/projectexplorer.h>
3232
#include <projectexplorer/projectexplorerconstants.h>
33+
#include <projectexplorer/projectexplorersettings.h>
3334
#include <projectexplorer/toolchain.h>
3435
#include <qtsupport/qtparser.h>
3536
#include <utils/stringutils.h>
@@ -262,8 +263,8 @@ ROSCatkinMakeStepWidget::ROSCatkinMakeStepWidget(ROSCatkinMakeStep *makeStep)
262263
connect(bc, &ROSBuildConfiguration::environmentChanged,
263264
this, &ROSCatkinMakeStepWidget::updateDetails);
264265

265-
connect(ProjectExplorerPlugin::instance(), SIGNAL(settingsChanged()),
266-
this, SLOT(updateDetails()));
266+
m_makeStep->project()->projectExplorerSettings().addOnChanged(
267+
this, std::bind(&ROSCatkinMakeStepWidget::updateDetails, this));
267268
}
268269

269270
ROSCatkinMakeStepWidget::~ROSCatkinMakeStepWidget()

src/project_manager/ros_catkin_tools_step.cpp

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,7 @@
3232
#include <projectexplorer/processparameters.h>
3333
#include <projectexplorer/projectexplorer.h>
3434
#include <projectexplorer/projectexplorerconstants.h>
35+
#include <projectexplorer/projectexplorersettings.h>
3536
#include <projectexplorer/toolchain.h>
3637
#include <qtsupport/qtparser.h>
3738
#include <utils/stringutils.h>
@@ -339,8 +340,8 @@ ROSCatkinToolsStepWidget::ROSCatkinToolsStepWidget(ROSCatkinToolsStep *makeStep)
339340
connect(bc, &ROSBuildConfiguration::environmentChanged,
340341
this, &ROSCatkinToolsStepWidget::updateDetails);
341342

342-
connect(ProjectExplorerPlugin::instance(), SIGNAL(settingsChanged()),
343-
this, SLOT(updateDetails()));
343+
m_makeStep->project()->projectExplorerSettings().addOnChanged(
344+
this, std::bind(&ROSCatkinToolsStepWidget::updateDetails, this));
344345

345346
Utils::VariableChooser::addSupportForChildWidgets(this, { makeStep, makeStep->rosBuildConfiguration()->macroExpander() });
346347
}

src/project_manager/ros_colcon_step.cpp

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,7 @@
3030
#include <projectexplorer/processparameters.h>
3131
#include <projectexplorer/projectexplorer.h>
3232
#include <projectexplorer/projectexplorerconstants.h>
33+
#include <projectexplorer/projectexplorersettings.h>
3334
#include <projectexplorer/toolchain.h>
3435
#include <qtsupport/qtparser.h>
3536
#include <utils/stringutils.h>
@@ -264,8 +265,8 @@ ROSColconStepWidget::ROSColconStepWidget(ROSColconStep *makeStep)
264265
connect(bc, &ROSBuildConfiguration::environmentChanged,
265266
this, &ROSColconStepWidget::updateDetails);
266267

267-
connect(ProjectExplorerPlugin::instance(), SIGNAL(settingsChanged()),
268-
this, SLOT(updateDetails()));
268+
m_makeStep->project()->projectExplorerSettings().addOnChanged(
269+
this, std::bind(&ROSColconStepWidget::updateDetails, this));
269270
}
270271

271272
ROSColconStepWidget::~ROSColconStepWidget()

0 commit comments

Comments
 (0)