Skip to content

Commit a30f0da

Browse files
christianrauchchristian-rauch
authored andcommitted
remove 'IOptionsPage' constructor call with 'parent' pointer
'IOptionsPage' only has a constructor taking a 'bool'. Calling this with the 'QObject' pointer will cast the pointer as bool value with unintended effects.
1 parent 4cdb653 commit a30f0da

File tree

2 files changed

+2
-5
lines changed

2 files changed

+2
-5
lines changed

src/project_manager/ros_settings_page.cpp

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -191,9 +191,7 @@ void ROSSettingsWidget::setSettings(const ROSSettings &s)
191191
}
192192

193193
// --------------- ROSSettingsPage
194-
ROSSettingsPage::ROSSettingsPage(QSharedPointer<ROSSettings> &settings,
195-
QObject *parent) :
196-
Core::IOptionsPage(parent),
194+
ROSSettingsPage::ROSSettingsPage(QSharedPointer<ROSSettings> &settings) :
197195
m_settings(settings)
198196
{
199197
setId(Constants::ROS_SETTINGS_MAIN_PAGE_ID);

src/project_manager/ros_settings_page.h

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -81,8 +81,7 @@ class ROSSettingsWidget : public Core::IOptionsPageWidget
8181
class ROSSettingsPage : public Core::IOptionsPage
8282
{
8383
public:
84-
explicit ROSSettingsPage(QSharedPointer<ROSSettings> &settings,
85-
QObject *parent = nullptr);
84+
explicit ROSSettingsPage(QSharedPointer<ROSSettings> &settings);
8685

8786
QWidget *widget() override;
8887
void apply() override;

0 commit comments

Comments
 (0)