ignore "range-loop-detach"

Author: christianrauch

src/project_manager/ros_package_wizard.cpp

@@ -255,7 +255,7 @@ Core::BaseFileWizard *ROSPackageWizard::create(const Core::WizardDialogParameter
     m_wizard->setProjectDirectory(rosProject->projectDirectory());
     m_wizard->setPath(defaultPath);
 
-    for (QWizardPage *p : m_wizard->extensionPages())
+    for (QWizardPage *p : m_wizard->extensionPages()) // clazy:exclude=range-loop-detach
         m_wizard->addPage(p);
 
     return m_wizard;

src/project_manager/ros_project_wizard.cpp

@@ -243,7 +243,7 @@ Core::BaseFileWizard *ROSProjectWizard::create(const Core::WizardDialogParameter
     Q_UNUSED(parameters);
     ROSProjectWizardDialog *wizard = new ROSProjectWizardDialog(this);
 
-    for (QWizardPage *p : wizard->extensionPages())
+    for (QWizardPage *p : wizard->extensionPages()) // clazy:exclude=range-loop-detach
         wizard->addPage(p);
 
     return wizard;
@@ -291,7 +291,7 @@ bool ROSProjectWizard::postGenerateFiles(const QWizard *w, const Core::Generated
     QSharedPointer<ROSSettings> ros_settings = ROSProjectPlugin::instance()->settings();
     TextEditor::CodeStylePool *code_style_pool = TextEditor::TextEditorSettings::codeStylePool(CppEditor::Constants::CPP_SETTINGS_ID);
 
-    for (const auto& code_style : code_style_pool->codeStyles()) {
+    for (const auto& code_style : code_style_pool->codeStyles()) { // clazy:exclude=range-loop-detach
         if (ros_settings->default_code_style == code_style->displayName()) {
             ProjectExplorer::EditorConfiguration *editorConfiguration = project->editorConfiguration();
             TextEditor::ICodeStylePreferences *codeStylePreferences = editorConfiguration->codeStyle(CppEditor::Constants::CPP_SETTINGS_ID);

src/project_manager/ros_run_configuration.cpp

@@ -125,7 +125,7 @@ ROSRunWorker::ROSRunWorker(RunControl *runControl) : RunWorker(runControl)
 
 void ROSRunWorker::start()
 {
-    for (RunStep *rs : qobject_cast<ROSRunConfiguration *>(runControl()->target()->activeRunConfiguration())->stepList()->steps())
+    for (RunStep *rs : qobject_cast<ROSRunConfiguration *>(runControl()->target()->activeRunConfiguration())->stepList()->steps()) // clazy:exclude=range-loop-detach
     {
         if (rs->enabled() == true && rs->id() != ROSProjectManager::Constants::ROS_ATTACH_TO_NODE_ID)
         {
@@ -152,7 +152,7 @@ ROSDebugRunWorker::ROSDebugRunWorker(RunControl *runControl) : Debugger::Debugge
 void ROSDebugRunWorker::start()
 {
     bool found = false;
-    for (RunStep *rs : qobject_cast<ROSRunConfiguration *>(runControl()->target()->activeRunConfiguration())->stepList()->steps())
+    for (RunStep *rs : qobject_cast<ROSRunConfiguration *>(runControl()->target()->activeRunConfiguration())->stepList()->steps()) // clazy:exclude=range-loop-detach
     {
         if (rs->enabled() == true && rs->id() == Constants::ROS_ATTACH_TO_NODE_ID)
         {
@@ -181,7 +181,7 @@ void ROSDebugRunWorker::start()
     if (found)
     {
         // Now that the watcher is started run all of the other steps
-        for (RunStep *rs : qobject_cast<ROSRunConfiguration *>(runControl()->target()->activeRunConfiguration())->stepList()->steps())
+        for (RunStep *rs : qobject_cast<ROSRunConfiguration *>(runControl()->target()->activeRunConfiguration())->stepList()->steps()) // clazy:exclude=range-loop-detach
         {
             if (rs->enabled() == true && rs->id() != ROSProjectManager::Constants::ROS_ATTACH_TO_NODE_ID)
             {
@@ -219,7 +219,7 @@ void ROSDebugRunWorker::findProcess()
     m_timeElapsed += 10;
     const QString &appName = Utils::FileUtils::normalizedPathName(m_debugTargetPath);
     Utils::ProcessInfo fallback;
-    for (const Utils::ProcessInfo &p : Utils::ProcessInfo::processInfoList()) {
+    for (const Utils::ProcessInfo &p : Utils::ProcessInfo::processInfoList()) { // clazy:exclude=range-loop-detach
         if (Utils::FileUtils::normalizedPathName(p.executable) == appName) {
             Core::MessageManager::writeSilently(tr("[ROS] Attaching to process: %1.").arg(appName));
             pidFound(p);

src/project_manager/ros_settings_page.cpp

@@ -54,7 +54,7 @@ ROSSettings::ROSSettings()
   {
     QDir ros_opt(ros_path.toFSPathString());
     ros_opt.setFilter(QDir::NoDotAndDotDot | QDir::Dirs);
-    for (const QString &entry : ros_opt.entryList())
+    for (const QString &entry : ros_opt.entryList()) // clazy:exclude=range-loop-detach
     {
       Utils::FilePath path = Utils::FilePath::fromString(QLatin1String(ROSProjectManager::Constants::ROS_INSTALL_DIRECTORY));
       path = path.pathAppended(entry);
@@ -131,12 +131,12 @@ ROSSettingsWidget::ROSSettingsWidget() :
     // TODO: Add python support
     TextEditor::CodeStylePool *code_style_pool = TextEditor::TextEditorSettings::codeStylePool(CppEditor::Constants::CPP_SETTINGS_ID);
 
-    for (const auto& code_style : code_style_pool->builtInCodeStyles()) {
+    for (const auto& code_style : code_style_pool->builtInCodeStyles()) { // clazy:exclude=range-loop-detach
         QString name = code_style->displayName() + " [built-in]";
         m_available_code_styles[name] = code_style->displayName();
     }
 
-    for (const auto& code_style : code_style_pool->customCodeStyles()) {
+    for (const auto& code_style : code_style_pool->customCodeStyles()) { // clazy:exclude=range-loop-detach
         QString name = code_style->displayName();
         if (name != "Global")
             m_available_code_styles[name] = name;