issues with the catkin_make step

[v4hn]

Similar to #444, the widget for the CatkinMake Step is not accessible, though there is a *Widget class defined in the code.

Additionally I tried to add CatkinMake Arguments, but the build just ignores them:

Browsing the sources I could not easily find the difference between the catkin tools step and the catkin_make step, but catkin_tools supports arguments:

[christian-rauch]

I think we should just remove the catkin_make support. catkin_make was superseded by catkin-tools (see https://catkin-tools.readthedocs.io/en/latest/migration.html for a migration guide).

If you have your CMake properly set up, you should also be able to use colcon for all ROS1/catkin packages. Using a single build tool for all ROS workspaces significantly reduces the maintenance costs.

[v4hn]

Since Dirk left the team, I'm not actually sure which build system is best-supported these days, but opinions definitely differ! catkin_make features ninja support and building packages as *one* cmake project. This reduces build time quite a bit in many cases. (roughly 1/5th performance boost on a workspace I tested today) For me, catkin tools mainly features explicit configuration of cmake/make arguments and extending workspace which are missing from the command line in catkin_make (they depend on the environment on first invocation). catkin/catkin_make only sees very few commits but by OR-related people. catkin tools is currently mostly maintained by a single master student at my university in their advanced studies. I've not looked into colcon, so I'm not sure what up or downsides it has. The only thing I've heard about it was that it was Dirk's way for a unified interface for ament and catkin.