Skip to content

Commit 8c23028

Browse files
committed
add missed rosdistro in super's get_subs_hooks
This commit add the missed rosdistro when call super's get_subs_hook in rosdebian or rosrpm. The release_history should be passed as **kwargs format since it have default value already. And I also combine two line in get_release_tag method since it's not exceed 120 lines.
1 parent d1aa11c commit 8c23028

File tree

3 files changed

+5
-8
lines changed

3 files changed

+5
-8
lines changed

bloom/generators/rosdebian.py

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,6 @@
3737
from bloom.generators.common import generate_substitutions_from_package
3838
from bloom.generators.common import sanitize_package_name
3939

40-
4140
from bloom.generators.debian import DebianGenerator
4241
from bloom.generators.debian import format_description
4342
from bloom.generators.debian import format_depends
@@ -81,7 +80,7 @@ def missing_dep_resolver(key, peer_packages, os_name, os_version, ros_distro):
8180

8281
@staticmethod
8382
def get_subs_hook(subs, package, rosdistro, releaser_history=None):
84-
subs = DebianGenerator.get_subs_hook(subs, package, releaser_history)
83+
subs = DebianGenerator.get_subs_hook(subs, package, rosdistro, releaser_history=releaser_history)
8584
subs['Package'] = rosify_package_name(subs['Package'], rosdistro)
8685

8786
# ROS 2 specific bloom extensions.
@@ -127,8 +126,7 @@ def generate_branching_arguments(self, package, branch):
127126
return args
128127

129128
def get_release_tag(self, data):
130-
return 'release/{0}/{1}/{2}-{3}'\
131-
.format(self.rosdistro, data['Name'], data['Version'], self.inc)
129+
return 'release/{0}/{1}/{2}-{3}'.format(self.rosdistro, data['Name'], data['Version'], self.inc)
132130

133131

134132
def rosify_package_name(name, rosdistro):

bloom/generators/rosrpm.py

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,7 @@ def missing_dep_resolver(key, peer_packages, os_name, os_version, ros_distro):
7979

8080
@staticmethod
8181
def get_subs_hook(subs, package, rosdistro, releaser_history=None):
82-
subs = RpmGenerator.get_subs_hook(subs, package, releaser_history)
82+
subs = RpmGenerator.get_subs_hook(subs, package, rosdistro, releaser_history=releaser_history)
8383
subs['Package'] = rosify_package_name(subs['Package'], rosdistro)
8484
return subs
8585

@@ -93,8 +93,7 @@ def generate_branching_arguments(self, package, branch):
9393
return args
9494

9595
def get_release_tag(self, data):
96-
return 'release/{0}/{1}/{2}-{3}'\
97-
.format(self.rosdistro, data['Name'], data['Version'], self.inc)
96+
return 'release/{0}/{1}/{2}-{3}'.format(self.rosdistro, data['Name'], data['Version'], self.inc)
9897

9998

10099
def rosify_package_name(name, rosdistro):

test/unit_tests/test_generators/test_common/test_generator.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
from ....utils.common import temporary_directory
1111
from ....utils.common import user
1212

13-
from bloom.generators.debian.generator import PackageManagerGenerator
13+
from bloom.generators.common import PackageManagerGenerator
1414

1515
from bloom.util import code
1616

0 commit comments

Comments
 (0)