Correctly export dependencies for downstream packages (#70)

(cherry picked from commit e33a5e9)

# Conflicts:
#	plugin_template/CMakeLists.txt
#	zlib_point_cloud_transport/CMakeLists.txt
#	zstd_point_cloud_transport/CMakeLists.txt

Author: FranzAlbers

draco_point_cloud_transport/CMakeLists.txt

@@ -16,13 +16,13 @@ find_package(std_msgs REQUIRED)
 find_package(Draco REQUIRED)
 
 set(dependencies
-  pluginlib::pluginlib
-  ${point_cloud_interfaces_TARGETS}
-  point_cloud_transport::point_cloud_transport
-  rclcpp::rclcpp
-  rcpputils::rcpputils
-  ${sensor_msgs_TARGETS}
-  ${std_msgs_TARGETS}
+  pluginlib
+  point_cloud_interfaces
+  point_cloud_transport
+  rclcpp
+  rcpputils
+  sensor_msgs
+  std_msgs
 )
 
 
@@ -37,7 +37,13 @@ add_library(${PROJECT_NAME}
 )
 
 target_link_libraries(${PROJECT_NAME} PRIVATE
-  ${dependencies}
+  pluginlib::pluginlib
+  ${point_cloud_interfaces_TARGETS}
+  point_cloud_transport::point_cloud_transport
+  rclcpp::rclcpp
+  rcpputils::rcpputils
+  ${sensor_msgs_TARGETS}
+  ${std_msgs_TARGETS}
 )
 
 # draco 1.5.3 dropped the DRACO_LIBRARIES variable in favor of

plugin_template/CMakeLists.txt

@@ -0,0 +1,64 @@
+# TODO (YourNameHere): This is not a working CMake Project!
+# Some assembly required for your plugin. (-:
+
+cmake_minimum_required(VERSION 3.10.2)
+
+set(CMAKE_CXX_STANDARD 17)
+
+project(template_point_cloud_transport)
+
+find_package(ament_cmake REQUIRED)
+find_package(pluginlib REQUIRED)
+find_package(point_cloud_interfaces REQUIRED)
+find_package(point_cloud_transport REQUIRED)
+find_package(rclcpp REQUIRED)
+# TODO (YourNameHere): You might need more dependencies
+
+set(dependencies
+  pluginlib
+  point_cloud_interfaces
+  point_cloud_transport
+  rclcpp
+)
+
+target_include_directories(${PROJECT_NAME} PRIVATE
+  "$<BUILD_INTERFACE:${CMAKE_CURRENT_SOURCE_DIR}/include>"
+  "$<INSTALL_INTERFACE:include/${PROJECT_NAME}>")
+
+add_library(${PROJECT_NAME}
+  SHARED
+  # TODO (YourNameHere): You might need more source files
+  src/manifest.cpp
+  src/template_publisher.cpp
+  src/template_subscriber.cpp
+)
+
+target_link_libraries(${PROJECT_NAME} PRIVATE
+  pluginlib::pluginlib
+  ${point_cloud_interfaces_TARGETS}
+  point_cloud_transport::point_cloud_transport
+  rclcpp::rclcpp
+)
+
+install(TARGETS ${PROJECT_NAME}
+  ARCHIVE DESTINATION lib
+  LIBRARY DESTINATION lib
+  RUNTIME DESTINATION lib/${PROJECT_NAME}
+)
+
+install(
+  DIRECTORY include/${PROJECT_NAME}/
+  DESTINATION include/${PROJECT_NAME}
+)
+
+pluginlib_export_plugin_description_file(point_cloud_transport template_plugins.xml)
+
+if(BUILD_TESTING)
+  find_package(ament_lint_auto REQUIRED)
+  ament_lint_auto_find_test_dependencies()
+endif()
+
+ament_export_include_directories(include)
+ament_export_libraries(${PROJECT_NAME})
+ament_export_dependencies(${dependencies})
+ament_package()

zlib_point_cloud_transport/CMakeLists.txt

@@ -29,9 +29,24 @@ add_library(${PROJECT_NAME}
   src/manifest.cpp
 )
 
+<<<<<<< HEAD
 target_link_libraries(${PROJECT_NAME} ZLIB::ZLIB)
 
 ament_target_dependencies(${PROJECT_NAME} ${dependencies})
+=======
+target_link_libraries(${PROJECT_NAME} PRIVATE
+  pluginlib::pluginlib
+  ${point_cloud_interfaces_TARGETS}
+  point_cloud_transport::point_cloud_transport
+  rclcpp::rclcpp
+  ZLIB::ZLIB
+)
+
+target_include_directories(${PROJECT_NAME} PRIVATE
+  "$<BUILD_INTERFACE:${CMAKE_CURRENT_SOURCE_DIR}/include>"
+  "$<INSTALL_INTERFACE:include/${PROJECT_NAME}>"
+)
+>>>>>>> e33a5e9 (Correctly export dependencies for downstream packages (#70))
 
 install(TARGETS ${PROJECT_NAME}
   ARCHIVE DESTINATION lib

zstd_point_cloud_transport/CMakeLists.txt

@@ -26,7 +26,17 @@ add_library(${PROJECT_NAME}
   src/manifest.cpp
 )
 
+<<<<<<< HEAD
 target_link_libraries(${PROJECT_NAME} zstd)
+=======
+target_link_libraries(${PROJECT_NAME} PRIVATE
+  pluginlib::pluginlib
+  ${point_cloud_interfaces_TARGETS}
+  point_cloud_transport::point_cloud_transport
+  rclcpp::rclcpp
+  zstd
+)
+>>>>>>> e33a5e9 (Correctly export dependencies for downstream packages (#70))
 
 ament_target_dependencies(${PROJECT_NAME} ${dependencies})