QoS conflict with joystick_drivers package

[roncapat]

teleop_tools/joy_teleop/joy_teleop/joy_teleop.py

Line 384 in d6fd091

reliability=rclpy.qos.QoSReliabilityPolicy.RELIABLE,

I run joystick_drivers's joy node, that publishes on topic /joy with BEST_EFFORT QoS setting.
However, this node subscribes with RELIABLE QoS setting, thus the subscription won't work.

Since the packages that modifies (see above) the default QoS is this one, I open an issue on this repo.

If you want, I can test and push a PR where subscription reliability is parametrized. Let me know if there are alternative solutions.

EDIT: sorry, now for some reason I can see that both pub and sub are RELIABLE

[bmagyar]

I think we should always use best effort here

[roncapat]

I'm not sure about the safety - I mean, may starting to loose incoming packets bring to an unsafe situation?

And/or

Shall we reopen the issue then to leave track of the needed change, if safe & needed?

[bmagyar]

Let's leave it open with the hopes of getting more philosophers joining the discussion and eventually reaching a conclusion