KeyError when using unknown severity levels (ros1_bridge)

[karl-schulz]

Hi!

When using the ROS1 bridge, the log messages get passed to ROS2 with different severity levels (1 instead of 10, 2 instead of 20, etc...). This causes a KeyError and an AssertionError in rqt_console/message_data_model.py:

KeyError:

rqt_console/src/rqt_console/message_data_model.py

Line 89 in 6084e59

data = Message.SEVERITY_LABELS[data]

AssertionError:

rqt_console/src/rqt_console/message_data_model.py

Line 112 in 6084e59

assert msg.severity in MessageDataModel.severity_colors, \

I fixed it locally for me - should I create pull request? Otherwise, rqt_console is basically not usable with a ROS1 bridge. Probably there are also other failure cases, as the gaps between severity levels in ROS2 were probably on purpose to let space for custom levels.

Thanks!
Karl

PS: Where is rqt_console for Foxy maintained?

[arne48]

Hello @karl-schulz,
thanks for investigating this issue and being willing to provide a fix.
I created a foxy-devel branch you can create a PR for.

Best,
Arne