items in lists are not removed if list in message is empty

[MatthijsBurgh]

When a message contains a list and the list has reduced to zero, the old list items are still shown. As the code which removes the list items is not reached when the list is empty.

The code that executes the deletion is

rqt_topic/src/rqt_topic/topic_widget.py

Lines 258 to 262 in befebd5

	# remove obsolete children
	if len(message) < self._tree_items[topic_name].childCount():
	for i in range(len(message), self._tree_items[topic_name].childCount()):
	item_topic_name = topic_name + '[%d]' % i
	self._recursive_delete_widget_items(self._tree_items[item_topic_name])

[audrow]

Thanks for pointing this out @MatthijsBurgh. If you want to make a PR for this, feel free to @ me as a reviewer.

[MatthijsBurgh]

I have tried in the past. I wasn't able to come up with a good solution then. It was hard to find good if/else conditions. Especially if you want to detect whether the list should be a list of messages. This is especially difficult if the list is empty.