Replies: 2 comments
|
Good question, I have been reverse-engineering what the previous maintainers were doing. My understanding is that it is: []{} : However, there is the added complexity of what to do when a single fix is applied to all recipes in a directory (eg. gazebo) so I have been known to replace with gazebo: in those situations. There is also a matter of the ideal length of the subject and message (see https://tbaggery.com/2008/04/19/a-note-about-git-commit-messages.html ). I try to follow the "best practices" where applicable but try to be pragmatic and will break it if it makes sense. One of my todo list items is to create a GitHub Action to automatically provide feedback on PR subjects but I haven't gotten to it. |
|
so keep the git commit summary the same as the PR @ github summary. Both, if possible, with []{}. |
Uh oh!
There was an error while loading. Please reload this page.
@robwoolley
Just to be clear, is it correct that the PR should have a header as "[Yocto]{ros} package: short description".
Is this the same for the git commit header? Or is it for the git commit header "{ros} package: short description"
Just to make sure you're huge task to keep track of all this PR is slightly more manageable for you.
All reactions