Skip to content

ROS2TalkerActivity.java logic issue:talkerNode.stop() will be run again , node will be stop twice?  #18

@pengzhouhu

Description

@pengzhouhu
when we click stop button,  OnClickListener() will run the changeState(false), this api will run the talkerNode.stop(), and when we down this, talkerNode.stop() will run again , so node will be stopped twice?

code path : ros2_android_examples/ros2_talker_android/src/main/java/org/ros2/examples/android/talker/ROS2TalkerActivity.java

just like below:

// Create an anonymous implementation of OnClickListener
private OnClickListener startListener = new OnClickListener() {
public void onClick(final View view) {
Log.d(logtag, "onClick() called - start button");
Toast
.makeText(ROS2TalkerActivity.this, "The Start button was clicked.",
Toast.LENGTH_LONG)
.show();
Log.d(logtag, "onClick() ended - start button");
Button buttonStart = (Button)findViewById(R.id.buttonStart);
Button buttonStop = (Button)findViewById(R.id.buttonStop);
changeState(true);
}
};

// Create an anonymous implementation of OnClickListener
private OnClickListener stopListener = new OnClickListener() {
public void onClick(final View view) {
Log.d(logtag, "onClick() called - stop button");
Toast
.makeText(ROS2TalkerActivity.this, "The Stop button was clicked.",
Toast.LENGTH_LONG)
.show();
changeState(false);
Log.d(logtag, "onClick() ended - stop button");
talkerNode.stop();

}
};

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions