chore: Reformat imports for consistency and clarity

Author: bresilla

rclrs/src/dynamic_message/dynamic_publisher.rs

@@ -1,13 +1,17 @@
-use std::ffi::CString;
-use std::sync::{Arc, Mutex};
+use std::{
+    ffi::CString,
+    sync::{Arc, Mutex},
+};
 
 use super::{
     get_type_support_handle, get_type_support_library, DynamicMessage, DynamicMessageError,
     DynamicMessageMetadata, MessageTypeName,
 };
-use crate::error::{RclrsError, ToResult};
-use crate::rcl_bindings::*;
-use crate::{Node, PublisherHandle, PublisherOptions, ENTITY_LIFECYCLE_MUTEX};
+use crate::{
+    error::{RclrsError, ToResult},
+    rcl_bindings::*,
+    Node, PublisherHandle, PublisherOptions, ENTITY_LIFECYCLE_MUTEX,
+};
 
 /// Struct for sending dynamic messages.
 ///
@@ -150,8 +154,7 @@ mod tests {
 
     #[test]
     fn test_dynamic_publishers() -> Result<(), RclrsError> {
-        use crate::vendor::test_msgs::msg;
-        use crate::TopicEndpointInfo;
+        use crate::{vendor::test_msgs::msg, TopicEndpointInfo};
 
         let namespace = "/test_dynamic_publishers_graph";
         let graph = construct_test_graph(namespace)?;

rclrs/src/dynamic_message/dynamic_subscription.rs

@@ -1,20 +1,22 @@
-use std::any::Any;
-use std::boxed::Box;
-use std::ffi::CString;
-use std::ops::{Deref, DerefMut};
-use std::sync::{Arc, Mutex};
+use std::{
+    any::Any,
+    boxed::Box,
+    ffi::CString,
+    ops::{Deref, DerefMut},
+    sync::{Arc, Mutex},
+};
 
 use futures::future::BoxFuture;
 
 use super::{
     get_type_support_handle, get_type_support_library, DynamicMessage, DynamicMessageMetadata,
     MessageStructure, MessageTypeName,
 };
-use crate::rcl_bindings::*;
 use crate::{
-    MessageInfo, Node, NodeHandle, RclPrimitive, RclPrimitiveHandle, RclPrimitiveKind, RclrsError,
-    RclrsErrorFilter, ReadyKind, SubscriptionHandle, SubscriptionOptions, ToResult, Waitable,
-    WaitableLifecycle, WorkScope, Worker, WorkerCommands, ENTITY_LIFECYCLE_MUTEX,
+    rcl_bindings::*, MessageInfo, Node, NodeHandle, RclPrimitive, RclPrimitiveHandle,
+    RclPrimitiveKind, RclrsError, RclrsErrorFilter, ReadyKind, SubscriptionHandle,
+    SubscriptionOptions, ToResult, Waitable, WaitableLifecycle, WorkScope, Worker, WorkerCommands,
+    ENTITY_LIFECYCLE_MUTEX,
 };
 
 /// Struct for receiving messages whose type is not known at compile time.

rclrs/src/dynamic_message/field_access.rs

@@ -889,10 +889,7 @@ mod immutable {
     define_value_types!(select_immutable);
 }
 
-pub use immutable::ArrayValue;
-pub use immutable::BoundedSequenceValue;
-pub use immutable::SequenceValue;
-pub use immutable::SimpleValue;
+pub use immutable::{ArrayValue, BoundedSequenceValue, SequenceValue, SimpleValue};
 
 /// The value of a field in a [`DynamicMessage`][1].
 ///
@@ -944,10 +941,10 @@ mod mutable {
     define_value_types!(select_mutable);
 }
 
-pub use mutable::ArrayValue as ArrayValueMut;
-pub use mutable::BoundedSequenceValue as BoundedSequenceValueMut;
-pub use mutable::SequenceValue as SequenceValueMut;
-pub use mutable::SimpleValue as SimpleValueMut;
+pub use mutable::{
+    ArrayValue as ArrayValueMut, BoundedSequenceValue as BoundedSequenceValueMut,
+    SequenceValue as SequenceValueMut, SimpleValue as SimpleValueMut,
+};
 
 /// The value of a field in a [`DynamicMessage`][1].
 ///

rclrs/src/dynamic_message/field_access/dynamic_bounded_string.rs

@@ -1,7 +1,9 @@
-use std::convert::AsMut;
-use std::fmt::{self, Display};
-use std::num::NonZeroUsize;
-use std::ops::{Deref, DerefMut};
+use std::{
+    convert::AsMut,
+    fmt::{self, Display},
+    num::NonZeroUsize,
+    ops::{Deref, DerefMut},
+};
 
 use rosidl_runtime_rs::StringExceedsBoundsError;
 

rclrs/src/dynamic_message/field_access/dynamic_message_view.rs

@@ -1,8 +1,12 @@
-use std::fmt::{self, Debug};
-use std::ops::Deref;
-
-use super::super::MessageStructure;
-use super::{DynamicSequenceElementMut, Proxy, ProxyMut, ProxySequence, Value, ValueMut};
+use std::{
+    fmt::{self, Debug},
+    ops::Deref,
+};
+
+use super::{
+    super::MessageStructure, DynamicSequenceElementMut, Proxy, ProxyMut, ProxySequence, Value,
+    ValueMut,
+};
 
 /// A view of a single message. Used for nested messages.
 ///

rclrs/src/dynamic_message/field_access/dynamic_sequence.rs

@@ -1,6 +1,8 @@
-use std::fmt::{self, Debug};
-use std::marker::PhantomData;
-use std::ops::{Deref, DerefMut};
+use std::{
+    fmt::{self, Debug},
+    marker::PhantomData,
+    ops::{Deref, DerefMut},
+};
 
 use rosidl_runtime_rs::{Sequence, SequenceAlloc, SequenceExceedsBoundsError};
 

rclrs/src/dynamic_message/message_structure.rs

@@ -1,10 +1,10 @@
-use std::ffi::CStr;
-use std::num::NonZeroUsize;
+use std::{ffi::CStr, num::NonZeroUsize};
 
 use super::TypeErasedSequence;
-use crate::rcl_bindings::rosidl_typesupport_introspection_c__MessageMember as rosidl_message_member_t;
-use crate::rcl_bindings::rosidl_typesupport_introspection_c__MessageMembers as rosidl_message_members_t;
-use crate::rcl_bindings::*;
+use crate::rcl_bindings::{
+    rosidl_typesupport_introspection_c__MessageMember as rosidl_message_member_t,
+    rosidl_typesupport_introspection_c__MessageMembers as rosidl_message_members_t, *,
+};
 
 /// Possible base types for fields in a message.
 // The field variants are self-explaining, no need to add redundant documentation.
@@ -298,8 +298,7 @@ impl MessageStructure {
 #[cfg(test)]
 mod tests {
     use super::*;
-    use crate::dynamic_message::*;
-    use crate::vendor::test_msgs::msg;
+    use crate::{dynamic_message::*, vendor::test_msgs::msg};
 
     use std::num::NonZeroUsize;
 

rclrs/src/lib.rs

@@ -192,10 +192,10 @@ mod node;
 mod parameter;
 mod publisher;
 mod qos;
-mod service;
 mod serialized_message;
 mod serialized_publisher;
 mod serialized_subscription;
+mod service;
 mod subscription;
 mod time;
 mod time_source;
@@ -223,10 +223,10 @@ pub use node::*;
 pub use parameter::*;
 pub use publisher::*;
 pub use qos::*;
+pub use rcl_bindings::rmw_request_id_t;
 pub use serialized_message::*;
 pub use serialized_publisher::*;
 pub use serialized_subscription::*;
-pub use rcl_bindings::rmw_request_id_t;
 pub use service::*;
 pub use subscription::*;
 pub use time::*;

rclrs/src/node.rs

@@ -43,13 +43,11 @@ use crate::{
     IntoAsyncSubscriptionCallback, IntoNodeServiceCallback, IntoNodeSubscriptionCallback,
     IntoNodeTimerOneshotCallback, IntoNodeTimerRepeatingCallback, IntoTimerOptions, LogParams,
     Logger, MessageInfo, ParameterBuilder, ParameterInterface, ParameterVariant, Parameters,
-    Promise, Publisher, PublisherOptions, PublisherState, RclrsError, RequestedGoal, Service,
-    ServiceOptions, ServiceState, SerializedPublisher, SerializedSubscription, Subscription,
-    SubscriptionOptions, SubscriptionState,
-    TerminatedGoal, TimeSource, Timer, TimerState, ToLogParams, Worker, WorkerOptions, WorkerState,
-    ENTITY_LIFECYCLE_MUTEX,
+    Promise, Publisher, PublisherOptions, PublisherState, RclrsError, RequestedGoal,
+    SerializedPublisher, SerializedSubscription, Service, ServiceOptions, ServiceState,
+    Subscription, SubscriptionOptions, SubscriptionState, TerminatedGoal, TimeSource, Timer,
+    TimerState, ToLogParams, ToResult, Worker, WorkerOptions, WorkerState, ENTITY_LIFECYCLE_MUTEX,
 };
-use crate::ToResult;
 
 /// A processing unit that can communicate with other nodes. See the API of
 /// [`NodeState`] to find out what methods you can call on a [`Node`].

rclrs/src/subscription.rs

@@ -620,8 +620,7 @@ mod tests {
 
     #[test]
     fn test_subscription_qos_settings() {
-        use crate::vendor::example_interfaces::msg::Empty;
-        use crate::*;
+        use crate::{vendor::example_interfaces::msg::Empty, *};
 
         let executor = Context::default().create_basic_executor();
 
@@ -672,8 +671,7 @@ mod tests {
 
     #[test]
     fn test_setting_qos_from_parameters() {
-        use crate::vendor::example_interfaces::msg::Empty;
-        use crate::*;
+        use crate::{vendor::example_interfaces::msg::Empty, *};
 
         let args = ["--ros-args", "-p", "qos_reliability:=best_effort"].map(ToString::to_string);