Tutorial out of date

[arjo129]

I was just following the following tutorial: https://github.com/ros2-rust/ros2_rust/blob/main/docs/writing-your-first-rclrs-node.md and discovered that the APIs have changed significantly since the last update of this tutorial.

[Guelakais]

Yep. the corrected version would look like this:

use rclrs::*;
use std::{thread, time::Duration};
use std_msgs::msg::String as StringMsg;

pub struct Middleman {
    worker: Worker<Option<String>>,
    publisher: Publisher<StringMsg>,
}

impl Middleman {
    fn new(executor: &Executor) -> Result<Self, RclrsError> {
        let node = executor.create_node("simple_subscription")?;
        let worker = node.create_worker(None);
        let publisher = node.create_publisher("publish_hello")?;
        worker.create_subscription::<StringMsg, _>(
            "publish_hello",
            move |data: &mut Option<String>, msg: StringMsg| {
                *data = Some(msg.data);
            },
        )?;

        Ok(Self { worker, publisher })
    }

    fn republish(&self) -> Result<(), RclrsError> {
        let publisher = self.publisher.clone();
        drop(
            self.worker
                .run(move |data: &mut Option<String>| -> Result<(), RclrsError> {
                    data.clone()
                        .map(|message| {
                            publisher.publish(StringMsg {
                                data: message.clone(),
                            })
                        })
                        .ok_or(RclrsError::RclError {
                            code: RclReturnCode::SubscriptionTakeFailed,
                            msg: None,
                        })??;
                    Ok(())
                }),
        );
        Ok(())
    }
}

fn main() -> Result<(), RclrsError> {
    let mut executor = Context::default_from_env()?.create_basic_executor();
    let node = Middleman::new(&executor)?;

    thread::spawn(move || {
        loop {
            thread::sleep(Duration::from_secs(1));
            if let Err(e) = node.republish() {
                eprintln!("Republish error: {}", e);
            }
        }
    });

    executor.spin(SpinOptions::default()).first_error()
}

[Guelakais]

I've looked at the corresponding document, and I could rewrite it if you'd like me to. However, I don't think it can easily be adapted due to the API changes. Moreover, I think it would make more sense to add it directly to the source code. For example, you could write a 'documentation.rs' module and republish it through 'lib.rs' as follows:

mod documentation;
pub use documentation::*;

Therefore, it should be available through docs.rs at the next release and it wouldn't polute he lib.rs to much. Additionally, a functional example should be added to the examples repository, because people would want to try it.

[vbalaji21]

I am interested to contribute to the ros2 rust community. I would like to know the process.
can i pick up this issue ?

[esteve]

@vbalaji21 that's awesome, thanks! I've assigned it to you, feel free to submit a PR and we can have a look at it 🙂

[vbalaji21]

@esteve thanks, I am excited to contribute. I am new to this repository, so it might take me little more time and iteration as this is my first PR for this repo.