Skip to content

rclcpp::NodeOptions arguments not honored with certain constructors of the player class #2088

@roncapat

Description

@roncapat

Description

With certain rosbag2_transport::Player constructors, like:

Player::Player(
std::unique_ptr<rosbag2_cpp::Reader> reader,
std::shared_ptr<KeyboardHandler> keyboard_handler,
const rosbag2_storage::StorageOptions & storage_options,
const rosbag2_transport::PlayOptions & play_options,
const std::string & node_name,
const rclcpp::NodeOptions & node_options)
: rclcpp::Node(
node_name,
rclcpp::NodeOptions(node_options).arguments(play_options.topic_remapping_options))
{
std::vector<reader_storage_options_pair_t> readers_with_options{};

existing node_options.arguments() are being discarded since they are overridden from the player options arguents. This prevents to set the node namespace, for example.

Metadata

Metadata

Assignees

Labels

bugSomething isn't working

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions