Skip to content

Conversation

@fujitatomoya
Copy link
Contributor

@fujitatomoya fujitatomoya commented Nov 11, 2025

Description

Is this user-facing behavior change?

Yes, but it gets only better.

Did you use Generative AI?

No

Additional Information

Note

Backports required to all downstream packages

@fujitatomoya fujitatomoya self-assigned this Nov 11, 2025
@fujitatomoya fujitatomoya added the bug Something isn't working label Nov 11, 2025
Copy link
Contributor Author

@fujitatomoya fujitatomoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MichaelOrlov can you review this?

Copy link
Contributor

@MichaelOrlov MichaelOrlov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MichaelOrlov MichaelOrlov changed the title add rosbag2_storage_default_plugins to exec_depend of ros2bag. Add rosbag2_storage_default_plugins to exec_depend of ros2bag. Nov 12, 2025
@ahcorde
Copy link
Contributor

ahcorde commented Nov 12, 2025

Pulls: #2227
Gist: https://gist.githubusercontent.com/ahcorde/f379ce896054e61a6bdc64e072f241e8/raw/f5293506f8758a06918639d3216d6f873a026f3f/ros2.repos
BUILD args: --packages-above-and-dependencies ros2bag
TEST args: --packages-above ros2bag
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/17470

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@ahcorde ahcorde merged commit a1b4bc5 into rolling Nov 13, 2025
12 checks passed
@ahcorde ahcorde deleted the fujiatomoya/add-default-plugin-exec_depend branch November 13, 2025 08:11
@ahcorde
Copy link
Contributor

ahcorde commented Nov 13, 2025

@fujitatomoya do we need to backport this one ?

@fujitatomoya
Copy link
Contributor Author

@Mergifyio backport kilted jazzy humble

@mergify
Copy link

mergify bot commented Nov 13, 2025

backport kilted jazzy humble

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Nov 13, 2025
mergify bot pushed a commit that referenced this pull request Nov 13, 2025
mergify bot pushed a commit that referenced this pull request Nov 13, 2025
ahcorde pushed a commit that referenced this pull request Nov 13, 2025
#2231)

(cherry picked from commit a1b4bc5)

Signed-off-by: Tomoya Fujita <[email protected]>
Co-authored-by: Tomoya Fujita <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ros2 bag record -h explodes with StopIteration exception

4 participants