Skip to content

Commit 1d3a703

Browse files
committed
refactor: Small reordering to have clearer logs
1 parent 839e17b commit 1d3a703

2 files changed

Lines changed: 17 additions & 16 deletions

File tree

src/core/process-coverage.ts

Lines changed: 11 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -134,30 +134,25 @@ export async function processCoverage(
134134
}
135135
}
136136

137-
// Apply filters to the coverage report
137+
// Filter files to exclude
138138
const globFilteredPackages: PackageCoverage[] = filterByGlob(mergedPackages, inputs.excludePatterns, logger)
139+
const overallMetrics = CoberturaCoverageParser.calculatePackageCoverage(globFilteredPackages)
140+
logger.info(
141+
`Calculated overall metrics (LineCoverage: ${overallMetrics.lineCoverage}, BranchCoverage: ${overallMetrics.branchCoverage})`,
142+
)
143+
144+
// Filter git changes
139145
const fileFilteredPackages = changedLinesPerFileMap
140146
? filterByChangedLines(globFilteredPackages, changedLinesPerFileMap, logger)
141147
: globFilteredPackages
142-
143-
// Read file contents from disk using resolved paths
144-
const fileContents = await readFileContents(fileFilteredPackages)
145-
146-
for (const filteredPackage of fileFilteredPackages) {
147-
for (const file of filteredPackage.files) {
148-
logger.debug?.(`Generating markdown for ${file.resolvedPath} with ${file.lines.length} changed lines`)
149-
}
150-
}
151-
152-
const overallMetrics = CoberturaCoverageParser.calculatePackageCoverage(globFilteredPackages)
153148
const prMetrics = CoberturaCoverageParser.calculatePackageCoverage(fileFilteredPackages)
154149
logger.info(
155-
`Calculated overall metrics (LineCoverage: ${overallMetrics.lineCoverage}, BranchCoverage: ${overallMetrics.branchCoverage})`,
156-
)
157-
logger.info(
158-
`Calculated PR metrics (LineCoverage: ${prMetrics.lineCoverage}, BranchCoverage: ${prMetrics.branchCoverage})`,
150+
`Calculated PR metrics (LineCoverage: ${prMetrics.lineCoverage}, BranchCoverage: ${prMetrics.branchCoverage})`,
159151
)
160152

153+
// Read file contents from disk using resolved paths
154+
const fileContents = await readFileContents(fileFilteredPackages)
155+
161156
// Generate Markdown from filtered report
162157
const markdown = generateMarkdown(
163158
fileFilteredPackages,

src/markdown/generator.ts

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -97,6 +97,12 @@ export function generateMarkdown(
9797
throw new Error(`maxCharacters must be at least ${MINIMUM_CHARACTERS}, got ${maxCharacters}`)
9898
}
9999

100+
for (const filteredPackage of packages) {
101+
for (const file of filteredPackage.files) {
102+
logger.debug?.(`Generating markdown for ${file.resolvedPath} with ${file.lines.length} changed lines`)
103+
}
104+
}
105+
100106
// Step 1: Generate fixed content (badges and legend)
101107
const badges = generateCoverageBadges(overallMetrics)
102108
const legend = generateLegend()

0 commit comments

Comments
 (0)