Fix/workaround cppcheck warnings about always true/false conditions

Author: rouault

frmts/raw/cpgdataset.cpp

@@ -1295,14 +1295,14 @@ CPLErr SIRC_QSLCRasterBand::IReadBlock(CPL_UNUSED int nBlockXOff,
     /*      Initialize our power table if this is our first time through.   */
     /* -------------------------------------------------------------------- */
     static float afPowTable[256];
-    [[maybe_unused]] static bool bPowTableInitialized = []()
+    [[maybe_unused]] static bool bPowTableInitialized = [](bool ret)
     {
         for (int i = 0; i < 256; i++)
         {
             afPowTable[i] = static_cast<float>(pow(2.0, i - 128));
         }
-        return true;
-    }();
+        return ret;
+    }(true);
 
     /* -------------------------------------------------------------------- */
     /*      Copy the desired band out based on the size of the type, and    */

frmts/zarr/crc32c.cpp

@@ -163,11 +163,11 @@ static void crc32c_init_hw(void) {
 /* Compute CRC-32C using the Intel hardware instruction. */
 static uint32_t crc32c_hw(uint32_t crc, void const *buf, size_t len) {
     /* populate shift tables the first time through */
-    static bool bInit = []()
+    static bool bInit = [](bool ret)
     {
         crc32c_init_hw();
-        return true;
-    }();
+        return ret;
+    }(true);
     (void)bInit;
 
     /* pre-process the crc */
@@ -273,7 +273,7 @@ static uint32_t crc32c_hw(uint32_t crc, void const *buf, size_t len) {
    version.  Otherwise, use the software version. */
 void crc32c_init(void) {
 
-    static const bool bInit = [](){
+    static const bool bInit = [](bool ret){
     int sse42;
 
     SSE42(sse42);
@@ -282,8 +282,8 @@ void crc32c_init(void) {
     } else {
         crc32c = crc32c_sw;
     }
-    return true;
-    }();
+    return ret;
+    }(true);
     (void)bInit;
 }
 
@@ -408,11 +408,11 @@ static void crc32c_init_sw_little(void) {
 uint32_t crc32c_sw_little(uint32_t crc, void const *buf, size_t len) {
     unsigned char const *next = static_cast<unsigned char const*>(buf);
 
-    static bool bInit = []()
+    static bool bInit = [](bool ret)
     {
         crc32c_init_sw_little();
-        return true;
-    }();
+        return ret;
+    }(true);
     (void)bInit;
 
     crc = ~crc;

frmts/zarr/vsikerchunk_json_ref.cpp

@@ -129,12 +129,14 @@ class VSIKerchunkJSONRefFileSystem final : public VSIFilesystemHandler
   public:
     VSIKerchunkJSONRefFileSystem()
     {
-        IsFileSystemInstantiated() = true;
+        bool *pbInstantiated = &IsFileSystemInstantiated();
+        *pbInstantiated = true;
     }
 
     ~VSIKerchunkJSONRefFileSystem() override
     {
-        IsFileSystemInstantiated() = false;
+        bool *pbInstantiated = &IsFileSystemInstantiated();
+        *pbInstantiated = false;
     }
 
     static bool &IsFileSystemInstantiated()

frmts/zarr/vsikerchunk_parquet_ref.cpp

@@ -60,7 +60,8 @@ class VSIKerchunkParquetRefFileSystem final : public VSIFilesystemHandler
   public:
     VSIKerchunkParquetRefFileSystem()
     {
-        IsFileSystemInstantiated() = true;
+        bool *pbInstantiated = &IsFileSystemInstantiated();
+        *pbInstantiated = true;
     }
 
     ~VSIKerchunkParquetRefFileSystem() override;
@@ -124,7 +125,8 @@ class VSIKerchunkParquetRefFileSystem final : public VSIFilesystemHandler
 VSIKerchunkParquetRefFileSystem::~VSIKerchunkParquetRefFileSystem()
 {
     CleanCache();
-    IsFileSystemInstantiated() = false;
+    bool *pbInstantiated = &IsFileSystemInstantiated();
+    *pbInstantiated = false;
 }
 
 /************************************************************************/

ogr/ogr_p.h

@@ -192,7 +192,7 @@ OGRGeometry CPL_DLL *OGRGeometryFromEWKB(GByte *pabyWKB, int nLength,
                                          int *pnSRID, int bIsPostGIS1_EWKB);
 OGRGeometry CPL_DLL *OGRGeometryFromHexEWKB(const char *pszBytea, int *pnSRID,
                                             int bIsPostGIS1_EWKB);
-char CPL_DLL *OGRGeometryToHexEWKB(OGRGeometry *poGeometry, int nSRSId,
+char CPL_DLL *OGRGeometryToHexEWKB(const OGRGeometry *poGeometry, int nSRSId,
                                    int nPostGISMajor, int nPostGISMinor);
 
 /************************************************************************/

ogr/ogrgeometry.cpp

@@ -7280,7 +7280,7 @@ OGRGeometry *OGRGeometryFromHexEWKB(const char *pszBytea, int *pnSRID,
 /*                        OGRGeometryToHexEWKB()                        */
 /************************************************************************/
 
-char *OGRGeometryToHexEWKB(OGRGeometry *poGeometry, int nSRSId,
+char *OGRGeometryToHexEWKB(const OGRGeometry *poGeometry, int nSRSId,
                            int nPostGISMajor, int nPostGISMinor)
 {
     const size_t nWkbSize = poGeometry->WkbSize();

ogr/ogrsf_frmts/amigocloud/ogramigocloudtablelayer.cpp

@@ -420,18 +420,15 @@ OGRErr OGRAmigoCloudTableLayer::ICreateFeature(OGRFeature *poFeature)
     // Add geometry field
     for (int i = 0; i < poFeatureDefn->GetGeomFieldCount(); i++)
     {
-        if (poFeature->GetGeomFieldRef(i) == nullptr)
+        const OGRGeometry *poGeom = poFeature->GetGeomFieldRef(i);
+        if (poGeom == nullptr)
             continue;
 
         record << "\""
                << OGRAMIGOCLOUDJsonEncode(
                       poFeatureDefn->GetGeomFieldDefn(i)->GetNameRef())
                << "\":";
 
-        OGRGeometry *poGeom = poFeature->GetGeomFieldRef(i);
-        if (poGeom == nullptr)
-            continue;
-
         OGRAmigoCloudGeomFieldDefn *poGeomFieldDefn =
             cpl::down_cast<OGRAmigoCloudGeomFieldDefn *>(
                 poFeatureDefn->GetGeomFieldDefn(i));

ogr/ogrsf_frmts/filegdb/FGdbDatasource.cpp

@@ -404,7 +404,7 @@ bool FGdbDataSource::LoadLayers(const std::wstring &root)
             m_osFSName, CPLSPrintf("a%08x", iGDBItems + 1), "gdbtable");
         std::unique_ptr<GDALDataset> poGDBItems(GDALDataset::Open(
             osGDBItems.c_str(), GDAL_OF_VECTOR, apszDrivers, nullptr, nullptr));
-        if (poGDBItems != nullptr && poGDBItems->GetLayer(0) != nullptr)
+        if (poGDBItems != nullptr)
         {
             if (OGRLayer *poItemsLayer = poGDBItems->GetLayer(0))
             {