Fix warning on Windows with libarrow 23

rouault · rouault · commit fcdefa362005 · 2026-01-25T00:53:55.000+01:00
diff --git a/ogr/ogrsf_frmts/parquet/ogrparquetlayer.cpp b/ogr/ogrsf_frmts/parquet/ogrparquetlayer.cpp
@@ -2971,8 +2971,8 @@ OGRErr OGRParquetLayer::SetNextByIndex(GIntBig nIndex)
     m_iRecordBatch = 0;
     for (int iGroup = 0; iGroup < nNumGroups; ++iGroup)
     {
-        const int64_t nNextAccRows =
-            nAccRows + metadata->RowGroup(iGroup)->num_rows();
+        const auto nRowsInRowGroup = metadata->RowGroup(iGroup)->num_rows();
+        const int64_t nNextAccRows = nAccRows + nRowsInRowGroup;
         if (nIndex < nNextAccRows)
         {
             if (!CreateRecordBatchReader(iGroup))
@@ -3010,8 +3010,7 @@ OGRErr OGRParquetLayer::SetNextByIndex(GIntBig nIndex)
         }
         nAccRows = nNextAccRows;
         m_iRecordBatch +=
-            (metadata->RowGroup(iGroup)->num_rows() + nBatchSize - 1) /
-            nBatchSize;
+            static_cast<int>(cpl::div_round_up(nRowsInRowGroup, nBatchSize));
     }
 
     m_iRecordBatch = -1;

Original file line number	Diff line number	Diff line change
`@@ -2971,8 +2971,8 @@ OGRErr OGRParquetLayer::SetNextByIndex(GIntBig nIndex)`
`2971`	`2971`	`m_iRecordBatch = 0;`
`2972`	`2972`	`for (int iGroup = 0; iGroup < nNumGroups; ++iGroup)`
`2973`	`2973`	`{`
`2974`		`- const int64_t nNextAccRows =`
`2975`		`- nAccRows + metadata->RowGroup(iGroup)->num_rows();`
	`2974`	`+ const auto nRowsInRowGroup = metadata->RowGroup(iGroup)->num_rows();`
	`2975`	`+ const int64_t nNextAccRows = nAccRows + nRowsInRowGroup;`
`2976`	`2976`	`if (nIndex < nNextAccRows)`
`2977`	`2977`	`{`
`2978`	`2978`	`if (!CreateRecordBatchReader(iGroup))`
`@@ -3010,8 +3010,7 @@ OGRErr OGRParquetLayer::SetNextByIndex(GIntBig nIndex)`
`3010`	`3010`	`}`
`3011`	`3011`	`nAccRows = nNextAccRows;`
`3012`	`3012`	`m_iRecordBatch +=`
`3013`		`- (metadata->RowGroup(iGroup)->num_rows() + nBatchSize - 1) /`
`3014`		`- nBatchSize;`
	`3013`	`+ static_cast<int>(cpl::div_round_up(nRowsInRowGroup, nBatchSize));`
`3015`	`3014`	`}`
`3016`	`3015`
`3017`	`3016`	`m_iRecordBatch = -1;`