Skip to content

Commit 5a63040

Browse files
authored
Merge pull request #65 from roussel-ryan/64-quick-fix-of-quadscandataset-transposed-plots
64 quick fix of quadscandataset plot
2 parents a20cb8c + f687119 commit 5a63040

File tree

3 files changed

+28
-148
lines changed

3 files changed

+28
-148
lines changed
-5.42 MB
Binary file not shown.

docs/examples/example_reconstruction_4d.ipynb

Lines changed: 21 additions & 143 deletions
Large diffs are not rendered by default.

gpsr/datasets.py

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -124,11 +124,13 @@ def __init__(self, parameters: Tensor, observations: Tuple[Tensor], screen: Scre
124124
Should have a shape of (K x 1) where K is the number of quadrupole strengths.
125125
observations : Tuple[Tensor]
126126
Tuple contaning tensor of observed images, where the tensor shape
127-
should be (K x bins x bins). First entry should be dipole off images.
128-
The images must follow the matrix convention, where axis -2 is Y and
129-
axis -1 is X.
127+
should be (K x bins x bins).The images must follow the matrix convention,
128+
where axis -2 is Y and axis -1 is X.
130129
screen: Screen
131130
Cheetah screen object that corresponds to the observed images.
131+
Note: screen resolution is in (x,y) order and image shape is in (y,x) order,
132+
so screen.resolution[0] == observations[0].shape[-1] and
133+
screen.resolution[1] == observations[0].shape[-2] must be true.
132134
133135
"""
134136

@@ -170,7 +172,7 @@ def plot_data(
170172
for i in range(n_k):
171173
ax[i].pcolormesh(
172174
*px_bin_centers,
173-
images[i][:-1, :-1].T / images[i].max(),
175+
images[i] / images[i].max(),
174176
rasterized=True,
175177
vmax=1.0,
176178
vmin=0,
@@ -183,7 +185,7 @@ def plot_data(
183185

184186
ax[i].contour(
185187
*px_bin_centers,
186-
overlay_image.T / overlay_image.max(),
188+
overlay_image / overlay_image.max(),
187189
**overlay_kwargs,
188190
)
189191

0 commit comments

Comments
 (0)