Fix race conditions in enhance-filter model updates and update-checker version string (#719)

* Initial plan

* Fix race conditions in enhance-filter and update-checker

Co-authored-by: umireon <[email protected]>

---------

Co-authored-by: copilot-swe-agent[bot] <[email protected]>
Co-authored-by: umireon <[email protected]>

Author: Copilot

src/enhance-filter.cpp

@@ -29,6 +29,8 @@ struct enhance_filter : public filter_data {
 	cv::Mat outputBGRA;
 	gs_effect_t *blendEffect;
 	float blendFactor;
+
+	std::mutex modelMutex;
 };
 
 const char *enhance_filter_getname(void *unused)
@@ -116,6 +118,9 @@ void enhance_filter_update(void *data, obs_data_t *settings)
 
 	if (tf->modelSelection.empty() || tf->modelSelection != newModel || tf->useGPU != newUseGpu ||
 	    tf->numThreads != newNumThreads) {
+		// Lock modelMutex to prevent race condition with video_tick
+		std::unique_lock<std::mutex> lock(tf->modelMutex);
+
 		tf->numThreads = newNumThreads;
 		tf->modelSelection = newModel;
 		if (tf->modelSelection == MODEL_ENHANCE_TBEFN) {
@@ -203,13 +208,16 @@ void enhance_filter_video_tick(void *data, float seconds)
 	}
 
 	cv::Mat outputImage;
-	try {
-		if (!runFilterModelInference(tf, imageBGRA, outputImage)) {
+	{
+		std::unique_lock<std::mutex> lock(tf->modelMutex);
+		try {
+			if (!runFilterModelInference(tf, imageBGRA, outputImage)) {
+				return;
+			}
+		} catch (const std::exception &e) {
+			obs_log(LOG_ERROR, "Exception caught: %s", e.what());
 			return;
 		}
-	} catch (const std::exception &e) {
-		obs_log(LOG_ERROR, "Exception caught: %s", e.what());
-		return;
 	}
 
 	// Put output image back to source rendering pipeline

src/update-checker/update-checker.cpp

@@ -7,9 +7,12 @@
 
 #include <plugin-support.h>
 
+#include <mutex>
+
 extern "C" const char *PLUGIN_VERSION;
 
 static std::string latestVersionForUpdate;
+static std::mutex latestVersionMutex;
 
 void check_update(void)
 {
@@ -35,10 +38,12 @@ void check_update(void)
 
 		if (info.version == PLUGIN_VERSION) {
 			// No update available, latest version is the same as the current version
+			std::lock_guard<std::mutex> lock(latestVersionMutex);
 			latestVersionForUpdate.clear();
 			return;
 		}
 
+		std::lock_guard<std::mutex> lock(latestVersionMutex);
 		latestVersionForUpdate = info.version;
 	};
 
@@ -47,6 +52,7 @@ void check_update(void)
 
 const char *get_latest_version(void)
 {
+	std::lock_guard<std::mutex> lock(latestVersionMutex);
 	obs_log(LOG_INFO, "get_latest_version: %s", latestVersionForUpdate.c_str());
 	if (latestVersionForUpdate.empty()) {
 		return nullptr;