Downgrade ONNX runtime to 1.20.1 for MacOS 12 compatibility (#249)

* Downgrade ONNX runtime to 1.20.1 for MacOS 12 compatibility

Later versions than this removed support for MacOS 12, but as we support the same MacOS versions as OBS which supports
MacOS 12, we want to keep supporting it too.

Also bump the minimum required version when using a system installed ONNX runtime, for consistency.

Fixes: #248

* Fix CMake formatting

* Remove ONNX error codes added in later versions of the lib

Author: Tabby

CMakeLists.txt

@@ -88,7 +88,7 @@ endif()
 
 if(USE_SYSTEM_ONNXRUNTIME)
   if(OS_LINUX)
-    find_package(Onnxruntime 1.16.3 REQUIRED)
+    find_package(Onnxruntime 1.20.1 REQUIRED)
     set(Onnxruntime_INCLUDE_PATH
         ${Onnxruntime_INCLUDE_DIR} ${Onnxruntime_INCLUDE_DIR}/onnxruntime
         ${Onnxruntime_INCLUDE_DIR}/onnxruntime/core/session ${Onnxruntime_INCLUDE_DIR}/onnxruntime/core/providers/cpu)

cmake/FetchOnnxruntime.cmake

@@ -8,7 +8,9 @@ set(CUSTOM_ONNXRUNTIME_HASH
     ""
     CACHE STRING "Hash of a downloaded ONNX Runtime tarball")
 
-set(Onnxruntime_VERSION "1.23.1")
+# v1.20.1 is the last version to support MacOS 12 v1.23.0 is the last version to support x86_64 on MacOS, as well as
+# MacOS 13
+set(Onnxruntime_VERSION "1.20.1")
 
 if(CUSTOM_ONNXRUNTIME_URL STREQUAL "")
   set(USE_PREDEFINED_ONNXRUNTIME ON)
@@ -25,17 +27,17 @@ if(USE_PREDEFINED_ONNXRUNTIME)
 
   if(APPLE)
     set(Onnxruntime_URL "${Onnxruntime_BASEURL}/onnxruntime-osx-universal2-${Onnxruntime_VERSION}.tgz")
-    set(Onnxruntime_HASH SHA256=e9fcd200bcf69377cc2c15e529368ca840d625669f34b1cf296a56b175665fc2)
+    set(Onnxruntime_HASH SHA256=da4349e01a7e997f5034563183c7183d069caadc1d95f499b560961787813efd)
   elseif(MSVC)
     set(Onnxruntime_URL "${Onnxruntime_BASEURL}/onnxruntime-win-x64-${Onnxruntime_VERSION}.zip")
-    set(OOnnxruntime_HASH SHA256=d57817ee1e1aec8a7b4973ded0536f9be19ce0aa2152ff06a07952ed44790ed7)
+    set(OOnnxruntime_HASH SHA256=78d447051e48bd2e1e778bba378bec4ece11191c9e538cf7b2c4a4565e8f5581)
   else()
     if(CMAKE_SYSTEM_PROCESSOR STREQUAL "aarch64")
       set(Onnxruntime_URL "${Onnxruntime_BASEURL}/onnxruntime-linux-aarch64-${Onnxruntime_VERSION}.tgz")
-      set(Onnxruntime_HASH SHA256=263267fa063c1a86d755268f492eabbc62887542c4a9417a21d628219805061a)
+      set(Onnxruntime_HASH SHA256=ae4fedbdc8c18d688c01306b4b50c63de3445cdf2dbd720e01a2fa3810b8106a)
     else()
       set(Onnxruntime_URL "${Onnxruntime_BASEURL}/onnxruntime-linux-x64-gpu-${Onnxruntime_VERSION}.tgz")
-      set(Onnxruntime_HASH SHA256=d759646b084888ded846f3be36aaadea24b62a19accba2d64ff9c2e3fb714a62)
+      set(Onnxruntime_HASH SHA256=6bfb87c6ebe55367a94509b8ef062239e188dccf8d5caac8d6909b2344893bf0)
     endif()
   endif()
 else()

src/whisper-utils/silero-vad-onnx.cpp

@@ -103,12 +103,6 @@ const char* ort_error_code_str(OrtErrorCode code)
 	  return "INVALID_GRAPH";
 	case OrtErrorCode::ORT_EP_FAIL:
 	  return "EP_FAIL";
-	case OrtErrorCode::ORT_MODEL_LOAD_CANCELED:
-	  return "MODEL_LOAD_CANCELED";
-	case OrtErrorCode::ORT_MODEL_REQUIRES_COMPILATION:
-	  return "MODEL_REQUIRES_COMPILATION";
-	case OrtErrorCode::ORT_NOT_FOUND:
-	  return "NOT_FOUND";
 	default:
 	  return "UNKNOWN_ERROR_CODE";
   }