Skip to content

Commit 1737cde

Browse files
authored
Merge pull request #17 from rpgoldman/fix-actions
Fix the actions to use bespoke Allegro image: clfoundation images are not actively maintained.
2 parents d3f55be + 01f48d7 commit 1737cde

File tree

2 files changed

+44
-17
lines changed

2 files changed

+44
-17
lines changed

.github/workflows/ci.yml

+42-15
Original file line numberDiff line numberDiff line change
@@ -15,23 +15,21 @@ on:
1515
jobs:
1616
test:
1717
# The type of runner that the job will run on
18-
runs-on: ${{matrix.os}}
19-
20-
container:
21-
image: clfoundation/${{matrix.lisp}}:latest
22-
2318
strategy:
2419
matrix:
25-
os: [ubuntu-latest]
26-
lisp:
27-
- sbcl
28-
- ccl
29-
- allegro
30-
# installation of quicklisp fails on Allegro for some reason. Have to fix this later.
20+
ro: [ubuntu-latest]
21+
lisp: [sbcl, ccl]
22+
# installation of quicklisp fails on Allegro for some
23+
# reason. Have to fix this later.
24+
25+
runs-on: ${{ matrix.ro }}
3126

3227
env:
3328
I_AGREE_TO_ALLEGRO_EXPRESS_LICENSE: yes
3429

30+
container:
31+
image: clfoundation/${{matrix.lisp}}:latest
32+
3533
steps:
3634
- name: install JSON wrangling binaries
3735
run: apt update && apt install -y jq python3 python3-pip && python3 -m pip install yq check-jsonschema
@@ -50,13 +48,42 @@ jobs:
5048
--load /asdf/asdf.lisp
5149
--load $GITHUB_WORKSPACE/do-test.lisp
5250
--eval '(uiop:quit 0)'
53-
- name: Allegro
54-
if: ${{ matrix.lisp == 'allegro' }}
55-
run: alisp -L /asdf/asdf.lisp -L $GITHUB_WORKSPACE/do-test.lisp
56-
--kill
5751
- name: Clozure
5852
if: ${{ matrix.lisp == 'ccl' }}
5953
run: ccl --batch
6054
--load /asdf/asdf.lisp
6155
--load $GITHUB_WORKSPACE/do-test.lisp
6256
--eval '(uiop:quit 0)'
57+
58+
test-allegro:
59+
# The type of runner that the job will run on
60+
strategy:
61+
matrix:
62+
ro: [ubuntu-latest]
63+
lisp: [allegro]
64+
# installation of quicklisp fails on Allegro for some
65+
# reason. Have to fix this later.
66+
67+
runs-on: ${{ matrix.ro }}
68+
69+
env:
70+
I_AGREE_TO_ALLEGRO_EXPRESS_LICENSE: yes
71+
72+
container:
73+
image: rpgoldman/allegro11express:latest
74+
75+
steps:
76+
- name: install JSON wrangling binaries
77+
run: apt update && apt install -y jq python3 python3-pip && python3 -m pip install yq check-jsonschema
78+
79+
- uses: actions/checkout@v3
80+
81+
- run: install-quicklisp
82+
83+
- name: install-modern-asdf
84+
run:
85+
mkdir /asdf && cd /asdf && wget https://asdf.common-lisp.dev/archives/asdf.lisp
86+
87+
- name: Allegro
88+
run: alisp -L /asdf/asdf.lisp -L $GITHUB_WORKSPACE/do-test.lisp
89+
--kill

hddl/hddl-pprint.lisp

+2-2
Original file line numberDiff line numberDiff line change
@@ -124,7 +124,7 @@ in the form of a list of actions."
124124
(parse-integer line :junk-allowed t)
125125
(collecting
126126
(cons id
127-
(ecase format
127+
(case format
128128
(:comma-separated
129129
(comma-separated-task->sexp (subseq (string-upcase line) (1+ pos))))
130130
(:s-expression
@@ -153,7 +153,7 @@ in the form of a list of actions."
153153
(partition-method-line (subseq line (1+ pos)))
154154
(declare (type string task-string method-id subtasks))
155155
(collecting `(,id
156-
,(ecase format
156+
,(case format
157157
(:default
158158
(space-separated-string->hddl-list (string-upcase task-string)))
159159
(:s-expression

0 commit comments

Comments
 (0)