Skip to content

Commit 3874aae

Browse files
committed
Add in simple CI
1 parent 588ba36 commit 3874aae

File tree

2 files changed

+32
-4
lines changed

2 files changed

+32
-4
lines changed

.github/workflows/ci.yml

Lines changed: 28 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,28 @@
1+
name: CI
2+
3+
on:
4+
push:
5+
branches: [ "master" ]
6+
pull_request:
7+
branches: [ "master" ]
8+
9+
jobs:
10+
# check python formatting
11+
ruff:
12+
runs-on: ubuntu-latest
13+
steps:
14+
- uses: actions/checkout@v4
15+
name: Checkout
16+
- uses: astral-sh/ruff-action@v3
17+
name: Ruff
18+
19+
# check cpp formatting
20+
clang-format:
21+
runs-on: ubuntu-latest
22+
steps:
23+
- uses: actions/checkout@v4
24+
name: Checkout
25+
- uses: jidicula/[email protected]
26+
name: Clang-Format
27+
with:
28+
clang-format-version: '20'

scripts/feature_param_tuning.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
from evalio import datasets as ds
1010
from pathlib import Path
1111

12-
from form import extract_keypoints_feature, KeypointExtractionParams_feature
12+
from form import extract_keypoints, KeypointExtractionParams
1313

1414

1515
recording_id = uuid.uuid4()
@@ -75,7 +75,7 @@ def update_keypoints(
7575
):
7676
scan, params_lidar = load_scan(dataset_name, sequence_name, index)
7777

78-
params_extract = KeypointExtractionParams_feature()
78+
params_extract = KeypointExtractionParams()
7979
params_extract.neighbor_points = neighbor_points
8080
params_extract.num_sectors = num_sectors
8181
params_extract.planar_feats_per_sector = planar_feats_per_sector
@@ -86,7 +86,7 @@ def update_keypoints(
8686
params_extract.min_norm_squared = params_lidar.min_range**2
8787
params_extract.max_norm_squared = params_lidar.max_range**2
8888

89-
planar, normals, points = extract_keypoints_feature(
89+
planar, normals, points = extract_keypoints(
9090
scan, # type: ignore
9191
params_extract,
9292
params_lidar,
@@ -124,7 +124,7 @@ def update_keypoints(
124124

125125

126126
# name, min, max, step
127-
params = KeypointExtractionParams_feature()
127+
params = KeypointExtractionParams()
128128
sliders = [
129129
["neighbor_points", 0, 10, 1],
130130
["num_sectors", 1, 10, 1],

0 commit comments

Comments
 (0)