mock --scrub=all doesn’t back up builds

[sergiomb2]

The error may have existed for a long time, and I’ve only just noticed it.

When config_opts['backup_on_clean'] = True, mock --scrub=all doesn’t back up the builds, unlike mock --init.

I’m reporting this now as it might be easy for you to resolve the issue. In the meantime, I’ll also look for a solution.

[praiskup]

Thank you for the report. Please see that (while clean() does) scrub() really isn't doing backups:

mock/mock/py/mockbuild/backend.py

Lines 81 to 94 in 710aec8

	@traceLog()
	def clean(self):
	"""clean out chroot with extreme prejudice :)"""
	if self.backup:
	self.backup_results()
	self.state.start("clean chroot")
	self.buildroot.delete()
	self.state.finish("clean chroot")
	@traceLog()
	def scrub(self, scrub_opts):
	"""clean out chroot and/or cache dirs with extreme prejudice :)"""
	statestr = "scrub %s" % scrub_opts
	self.state.start(statestr)

This is a low-priority issue for us, though, as none of our deployments rely on backup_on_clean. The machines we use are mostly ephemeral (or we treat even the result directory as ephemeral), and once a build finishes, we store the results in their appropriate locations.

[sergiomb2]

Hi, it seems to me we just need to add the same two lines in the def scrub function. I don't see a better way. Maybe look for other places where buildroot.delete is used.

    if self.backup:
        self.backup_results()