Skip to content

Improve lints.#111

Merged
github-actions[bot] merged 1 commit intomainfrom
neal/improve-lints
Mar 25, 2026
Merged

Improve lints.#111
github-actions[bot] merged 1 commit intomainfrom
neal/improve-lints

Conversation

@nwalfield
Copy link
Copy Markdown
Collaborator

  - When including an error in a lint, don't just include the
    top-level error, but also the causes.

  - Fixes #110.
@github-actions
Copy link
Copy Markdown

* 4a6e83c723b33e907a0943a3c7b1e262b6bec5ea Improve lints.
|   - Authorized by Neal H. Walfield <neal@pep.foundation> [F7173B3C7C685CD9ECC4191B74E445BA0E15C957]
* 140fd7eea182d8d58718572f89a85fe3eec29741 Release v1.10.1.
    - Trust root.

The pull request's base (140fd7e) authenticates the pull request's head (4a6e83c).

@nwalfield
Copy link
Copy Markdown
Collaborator Author

@pmatilai do you know why we might be getting this failure?

   [2/2] STEP 5/7: RUN cmake --preset dev-${TOOLCHAIN} -DMKTREE_BACKEND=rootfs ../rpm
  CMake Error: No such preset in /srv/rpm: "dev-"
  Available configure presets:
  
    "full"            - Full feature set
    "toolchain-gcc"   - GNU C/C++ toolchain
    "toolchain-clang" - Clang toolchain
    "dev"             - Development mode (default toolchain)
    "dev-gcc"         - Development mode (GNU C/C++ toolchain)
    "dev-clang"       - Development mode (Clang toolchain)
  Error: building at STEP "RUN cmake --preset dev-${TOOLCHAIN} -DMKTREE_BACKEND=rootfs ../rpm": while running runtime: exit status 1
  Error: Process completed with exit code 1.

@pmatilai
Copy link
Copy Markdown
Member

@dmnks will have a better idea 😄

@nwalfield-rh
Copy link
Copy Markdown

@dmnks Do you have any idea why this is failing? Thanks in advance.

@dmnks
Copy link
Copy Markdown

dmnks commented Mar 25, 2026

@nwalfield, my apologies, I missed the original nudge (notification email)!

So it turns out, this is a bug recent regression in our Dockerfile, which I've just fixed here: rpm-software-management/rpm#4164. Once it's merged, you can re-run the CI job here and it should work.

Thanks!

@pmatilai
Copy link
Copy Markdown
Member

Once it's merged

Merged now.

@nwalfield
Copy link
Copy Markdown
Collaborator Author

@nwalfield, my apologies, I missed the original nudge (notification email)!

No worries.

So it turns out, this is a bug recent regression in our Dockerfile, which I've just fixed here

Thank you!

@nwalfield
Copy link
Copy Markdown
Collaborator Author

Ok, it's now failing as follows:

  --- -	2026-03-25 10:52:48.849416757 +0000
  +++ /srv/rpmtests.dir/at-groups/102/stderr	2026-03-25 10:52:48.847590623 +0000
  @@ -1,3 +1,3 @@
   error: Certificate 7F1C21F95F65BBE8:
  -  Policy rejects 7F1C21F95F65BBE8: Policy rejected asymmetric algorithm
  +  Policy rejects 7F1C21F95F65BBE8: Policy rejected asymmetric algorithm, because NistP256 is not considered secure

This is expected as this PR changes the output. Since the test is part of RPM, RPM will need to somehow adjust this (cc: @pmatilai, @dmnks)

@nwalfield
Copy link
Copy Markdown
Collaborator Author

/fast-forward

@github-actions github-actions Bot merged commit 4a6e83c into main Mar 25, 2026
11 of 14 checks passed
@dmnks
Copy link
Copy Markdown

dmnks commented Mar 25, 2026

Filed #4166.

@nwalfield
Copy link
Copy Markdown
Collaborator Author

Thanks!

@nwalfield nwalfield deleted the neal/improve-lints branch March 25, 2026 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Vague error message when importing certificates signed with SHA1

4 participants