patch-not-applied when using %forgeautosetup macro that wraps %autosetup

[kaechele]

When a macro wraps another macro that applies patches (as with %forgeautosetup which wraps %autosetup in Fedora), patches should be deemed applied.

[damaestro]

I've also ran into this during package review.

I had split back out to %forgesetup and %autopatch -p1 to address this finding. When going through review, it was requested to change back to %forgeautosetup -p1.

rpmlint should be updated for this as %forgeautosetup does correctly apply patches.

[Conan-Kudo]

As %forgeautosetup is not an upstream RPM macro, it is not eligible to be included in rpmlint code.

[damaestro]

Well... darn. Does that mean we (packagers) should use %forgesetup and %autopatch -p1? Does that mean that all reviewers of packages need to now know that %forgeautosetup is also working but not in conformance?

[Conan-Kudo]

All packagers do need to be aware that %forgeautosetup is fine despite the error, yes. The way %forgeautosetup expands makes it so rpmlint can't see that it uses %autosetup underneath, maybe check with the forge-srpm-macros developer or the rpm folks to see if there's a solution.