"info recording" command that gives the path to the recording

Author: timo

CMakeLists.txt

@@ -1605,6 +1605,7 @@ set(TESTS_WITH_PROGRAM
   ignored_sigsegv
   ignore_nested
   immediate_restart
+  info_recording
   x86/int3_ok
   interrupt
   intr_ptrace_decline

src/DebuggerExtensionCommand.cc

@@ -4,6 +4,7 @@
 
 #include "ReplayTask.h"
 #include "log.h"
+#include "util.h"
 
 using namespace std;
 
@@ -56,6 +57,21 @@ static SimpleDebuggerExtensionCommand when_tid(
       return string("Current tid: ") + to_string(t->tid);
     });
 
+static SimpleDebuggerExtensionCommand info_recording(
+    "info recording",
+    "Print the path of the recording RR is"
+    " currently replaying.",
+    [](GdbServer&, Task* t, const vector<string>&) {
+      if (!t->session().is_replaying()) {
+        return DebuggerExtensionCommandHandler::cmd_end_diversion();
+      }
+
+      auto task = static_cast<ReplayTask*>(t);
+      auto trace_dir = task->session().as_replay()->trace_reader().dir();
+
+      return string("Path of recording: \"") + json_escape(trace_dir) + string("\"");
+    });
+
 static std::vector<ReplayTimeline::Mark> back_stack;
 static ReplayTimeline::Mark current_history_cp;
 static std::vector<ReplayTimeline::Mark> forward_stack;

src/test/info_recording.c

@@ -0,0 +1,12 @@
+/* -*- Mode: C; tab-width: 8; c-basic-offset: 2; indent-tabs-mode: nil; -*- */
+
+#include "util.h"
+
+int main(int argc, char *argv[]) {
+  if (argc <= 1) {
+    atomic_puts("Hi");
+  } else {
+    atomic_puts(argv[1]);
+  }
+  return 0;
+}

src/test/info_recording.py

@@ -0,0 +1,19 @@
+from util import *
+
+import re
+import json
+
+send_gdb('info recording')
+expect_gdb(re.compile(r'(?<=Path of recording: ).*'))
+path_jsonstr = last_match().group(0)
+path_pystr   = json.loads(path_jsonstr)
+
+if len(path_pystr) < 6:
+    failed("ERROR ... Unreasonably short path for recording file found in output")
+
+# Inferior command also has the name of the binary at the end,
+# so the pattern matches opening but not closing paren.
+send_gdb("inferior")
+expect_gdb(f"\\({path_pystr}")
+
+ok()

src/test/info_recording.run

@@ -0,0 +1,2 @@
+source `dirname $0`/util.sh
+debug_test_gdb_only