Use DacFx for SQL Server 2022 (#363)

* Use DacFx for SQL Server 2022

Use microsoft.sqlpackage on container

* use old default value

* Make it optional

* add test

Co-authored-by: Erik Ejlskov Jensen <[email protected]>

Author: ErikEJ

.github/workflows/main.yml

@@ -220,17 +220,19 @@ jobs:
         name: dacpac-package
         path: ~/dacpac-package
 
-    # Download sqlpackage
-    - name: download sqlpackage
-      run: >
-        curl -L https://go.microsoft.com/fwlink/?linkid=2113331 --output sqlpackage.zip &&
-        unzip sqlpackage.zip -d ~/sqlpackage &&
-        chmod a+x ~/sqlpackage/sqlpackage
+    # Setup .NET SDK
+    - uses: actions/setup-dotnet@v3
+      with:
+        dotnet-version: '6.0.x'
+
+    # Install Microsoft.SqlPackage
+    - name: install microsoft.sqlpackage
+      run: dotnet tool install --tool-path . microsoft.sqlpackage
 
     # Run sqlpackage
     - name: sqlpackage publish
       run: >
-        ~/sqlpackage/sqlpackage
+        sqlpackage
         /Action:Publish
         /SourceFile:$HOME/dacpac-package/TestProjectWithSDKRef.dacpac
         /Properties:IncludeCompositeObjects=True

src/DacpacTool/DacpacTool.csproj

@@ -1,4 +1,4 @@
-<Project Sdk="Microsoft.NET.Sdk">
+<Project Sdk="Microsoft.NET.Sdk">
 
   <PropertyGroup>
     <OutputType>Exe</OutputType>
@@ -12,7 +12,7 @@
   </PropertyGroup>
 
   <ItemGroup>
-    <PackageReference Include="Microsoft.SqlServer.DACFX" Version="160.6296.0" />
+    <PackageReference Include="Microsoft.SqlServer.DacFx" Version="161.6374.0" />
     <PackageReference Include="System.CommandLine" Version="2.0.0-beta1.21308.1" />
   </ItemGroup>
 

src/DacpacTool/DeployOptions.cs

@@ -1,4 +1,4 @@
-using System.IO;
+using System.IO;
 
 namespace MSBuild.Sdk.SqlProj.DacpacTool
 {
@@ -13,5 +13,6 @@ public class DeployOptions : BaseOptions
         public string[] Property { get; set; }
         public string[] SqlCmdVar { get; set; }
         public bool RunScriptsFromReferences { get; set; }
+        public bool Encrypt { get; set; } = false;
     }
 }

src/DacpacTool/PackageDeployer.cs

@@ -1,4 +1,4 @@
-using System;
+using System;
 using System.IO;
 using System.Linq;
 using Microsoft.Data.SqlClient;
@@ -55,6 +55,12 @@ public void UseWindowsAuthentication()
             _console.WriteLine("Using Windows Authentication");
         }
 
+        public void UseEncrypt(bool encrypt)
+        {
+            ConnectionStringBuilder.Encrypt = encrypt;
+            _console.WriteLine($"Using encrypt: {encrypt}");
+        }
+
         public void SetSqlCmdVariable(string key, string value)
         {
             if (string.IsNullOrWhiteSpace(key))

src/DacpacTool/Program.cs

@@ -62,6 +62,7 @@ static async Task<int> Main(string[] args)
                 new Option<string[]>(new string[] { "--property", "-p" }, "Properties used to control the deployment"),
                 new Option<string[]>(new string[] { "--sqlcmdvar", "-sc" }, "SqlCmdVariable(s) and their associated values, separated by an equals sign."),
                 new Option<bool>(new string[] { "--runScriptsFromReferences", "-sff" }, "Whether to run pre- and postdeployment scripts from references"),
+                new Option<bool>(new string[] { "--encrypt", "-e" }, "Encrypt the connection, defaults to false"),
 #if DEBUG
                 new Option<bool>(new string[] { "--debug" }, "Waits for a debugger to attach")
 #endif
@@ -229,6 +230,8 @@ private static int DeployDacpac(DeployOptions options)
                     deployer.SetDeployProperties(options.Property);
                 }
 
+                deployer.UseEncrypt(options.Encrypt);
+
                 if (options.SqlCmdVar != null)
                 {
                     foreach (var sqlCmdVar in options.SqlCmdVar)

test/DacpacTool.Tests/PackageDeployerTests.cs

@@ -1,4 +1,4 @@
-using System;
+using System;
 using System.IO;
 using Microsoft.SqlServer.Dac;
 using Microsoft.VisualStudio.TestTools.UnitTesting;
@@ -53,6 +53,32 @@ public void UseWindowsAuthentication()
             packageDeployer.ConnectionStringBuilder.IntegratedSecurity.ShouldBeTrue();
         }
 
+        [TestMethod]
+        public void UseEncrypt()
+        {
+            // Arrange
+            var packageDeployer = new PackageDeployer(_console);
+
+            // Act
+            packageDeployer.UseEncrypt(true);
+
+            // Assert
+            packageDeployer.ConnectionStringBuilder.Encrypt.ShouldBe(Microsoft.Data.SqlClient.SqlConnectionEncryptOption.Mandatory);
+        }
+
+        [TestMethod]
+        public void EncryptDefault()
+        {
+            // Arrange
+            var packageDeployer = new PackageDeployer(_console);
+
+            // Act
+            packageDeployer.UseEncrypt(false);
+
+            // Assert
+            packageDeployer.ConnectionStringBuilder.Encrypt.ShouldBe(Microsoft.Data.SqlClient.SqlConnectionEncryptOption.Optional);
+        }
+
         [TestMethod]
         public void UseSqlServerAuthenticationNoPasswordPrompts()
         {