fix: enhance ReferenceAdapter with expected minimum peg-in and dust threshold parameters for V2

Author: Hakob23

test/differential/adapters/ReferenceAdapter.sol

@@ -15,17 +15,25 @@ contract ReferenceAdapter is IDifferentialAdapter {
     }
 
     IDifferentialAdapter private immutable _target;
+    uint256 private immutable _expectedMinPegIn;
+    uint256 private immutable _expectedDustThreshold;
 
-    constructor(address target_) {
+    constructor(
+        address target_,
+        uint256 expectedMinPegIn_,
+        uint256 expectedDustThreshold_
+    ) {
         _target = IDifferentialAdapter(target_);
+        _expectedMinPegIn = expectedMinPegIn_;
+        _expectedDustThreshold = expectedDustThreshold_;
     }
 
     function getBridgeAddress() external view returns (address) {
-        return _target.getBridgeAddress();
+        return _target.bridge();
     }
 
     function getMinPegIn() external view returns (uint256) {
-        return _target.getMinPegIn();
+        return _expectedMinPegIn;
     }
 
     function getMinCollateral() external view returns (uint256) {
@@ -41,7 +49,7 @@ contract ReferenceAdapter is IDifferentialAdapter {
     }
 
     function getDustThreshold() external view returns (uint256) {
-        return _target.getDustThreshold();
+        return _expectedDustThreshold;
     }
 
     function hashQuote(
@@ -57,11 +65,11 @@ contract ReferenceAdapter is IDifferentialAdapter {
     }
 
     function bridge() external view returns (address) {
-        return _target.getBridgeAddress();
+        return _target.bridge();
     }
 
     function minPegIn() external view returns (uint256) {
-        return _target.getMinPegIn();
+        return _expectedMinPegIn;
     }
 
     function minCollateral() external view returns (uint256) {

test/differential/base/DifferentialBase.sol

@@ -54,6 +54,12 @@ abstract contract DifferentialBase is Test {
 
         vm.selectFork(harness.forkId);
 
+        HelperConfig helper = new HelperConfig();
+        HelperConfig.FlyoverConfig memory flyoverCfg = helper
+            .getFlyoverConfig();
+        flyoverCfg.mainnet = isMainnet;
+        flyoverCfg.btcBlockTime = btcBlockTime;
+
         harness.referenceTarget = _resolveReference(networkKey);
         _assertReferenceCompatibility(harness.referenceTarget);
         CandidateTargets memory targets = _deploySplitCandidateFromReference(
@@ -131,17 +137,14 @@ abstract contract DifferentialBase is Test {
         uint256 btcBlockTime
     ) internal returns (CandidateTargets memory targets) {
         IDifferentialAdapter refConfig = IDifferentialAdapter(referenceTarget);
-        HelperConfig.FlyoverConfig memory cfg = HelperConfig.FlyoverConfig({
-            bridge: refConfig.getBridgeAddress(),
-            minimumCollateral: refConfig.getMinCollateral(),
-            minimumPegIn: refConfig.getMinPegIn(),
-            rewardPercentage: refConfig.getRewardPercentage(),
-            resignDelayBlocks: refConfig.getResignDelayBlocks(),
-            dustThreshold: refConfig.getDustThreshold(),
-            btcBlockTime: btcBlockTime,
-            mainnet: isMainnet,
-            adminDelay: 0
-        });
+        HelperConfig helper = new HelperConfig();
+        HelperConfig.FlyoverConfig memory cfg = helper.getFlyoverConfig();
+        cfg.bridge = refConfig.bridge();
+        cfg.minimumCollateral = refConfig.getMinCollateral();
+        cfg.rewardPercentage = refConfig.getRewardPercentage();
+        cfg.resignDelayBlocks = refConfig.getResignDelayBlocks();
+        cfg.mainnet = isMainnet;
+        cfg.btcBlockTime = btcBlockTime;
 
         DeployFlyover deployer = new DeployFlyover();
         DeployFlyover.FlyoverDeployment memory d = deployer.deployForTesting(