fix: copilot suggestions

Author: Luisfc68

src/libraries/SignatureValidator.sol

@@ -8,9 +8,10 @@ library SignatureValidator {
     using ECDSA for bytes32;
 
     error IncorrectSignature(address expectedAddress, bytes32 usedHash, bytes signature);
+    error SignatureCheckError(uint8 errorType, bytes32 errorArg);
     error ZeroAddress();
     /**
-        @dev Verfies signature against address
+        @dev Verifies signature against address
         @param addr The signing address
         @param messageHash The hash of the signed message, the SignatureValidator won't perform any
         modification on the message. If this is used for EIP712, this contract expects it to be the
@@ -27,6 +28,10 @@ library SignatureValidator {
         if (signature.length != 65) {
             revert IncorrectSignature(addr, messageHash, signature);
         }
-        return  messageHash.recover(signature) == addr;
+        (address recovered, ECDSA.RecoverError err, bytes32 errorArg) = messageHash.tryRecover(signature);
+        if (err != ECDSA.RecoverError.NoError) {
+            revert SignatureCheckError(uint8(err), errorArg);
+        }
+        return recovered == addr;
     }
 }

test/fuzz/pegin/PegInFuzzTestBase.sol

@@ -140,7 +140,7 @@ abstract contract PegInFuzzTestBase is PegInTestBase {
     /// @notice Signs a quote with the appropriate LP private key
     /// @param signer The signer address (must be one of the registered LPs)
     /// @param quote The quote to sign
-    /// @return signature The EIP-191 signature
+    /// @return signature The EIP-712 signature over the typed-data hash of the quote
     function signFuzzQuote(
         address signer,
         Quotes.PegInQuote memory quote

test/fuzz/pegout/PegOutFuzzTestBase.sol

@@ -169,7 +169,7 @@ abstract contract PegOutFuzzTestBase is PegOutTestBase {
     /// @notice Signs a quote hash with the appropriate LP private key
     /// @param signer The signer address (must be one of the registered LPs)
     /// @param quote The quote to sign
-    /// @return signature The EIP-191 signature
+    /// @return signature The EIP-712 typed-data signature for the quote
     function signFuzzQuote(
         address signer,
         Quotes.PegOutQuote memory quote

test/pegin/Hashing.t.sol

@@ -170,12 +170,14 @@ contract HashingTest is PegInTestBase {
         // Test chainId
         modifiedQuote = baseQuote;
         modifiedQuote.chainId = baseQuote.chainId + 1;
+        uint originalChainId = block.chainid;
         vm.chainId(modifiedQuote.chainId); // to prevent the hash from failing
         assertTrue(
             pegInContract.hashPegInQuote(modifiedQuote) != baseHash,
             "chainId should affect hash"
         );
-
+        vm.chainId(originalChainId);
+        modifiedQuote.chainId = originalChainId;
         // Test callFee
         modifiedQuote = baseQuote;
         modifiedQuote.callFee = baseQuote.callFee + 1;

test/pegout/Hashing.t.sol

@@ -4,6 +4,7 @@ pragma solidity 0.8.25;
 import {PegOutTestBase} from "./PegOutTestBase.sol";
 import {Quotes} from "../../src/libraries/Quotes.sol";
 import {Flyover} from "../../src/libraries/Flyover.sol";
+import {console} from "forge-std/console.sol";
 
 contract HashingTest is PegOutTestBase {
     function setUp() public {
@@ -110,11 +111,14 @@ contract HashingTest is PegOutTestBase {
         // Test chainId
         modifiedQuote = baseQuote;
         modifiedQuote.chainId = baseQuote.chainId + 1;
+        uint originalChainId = block.chainid;
         vm.chainId(modifiedQuote.chainId); // to prevent the hash from failing
         assertTrue(
             pegOutContract.hashPegOutQuote(modifiedQuote) != baseHash,
             "chainId should affect hash"
         );
+        modifiedQuote.chainId = originalChainId;
+        vm.chainId(originalChainId);
 
         // Test callFee
         modifiedQuote = baseQuote;