test: update new tests

Author: Luisfc68

foundry.lock

@@ -1,13 +1,16 @@
 {
-  "lib/forge-std": {
-    "rev": "8bbcf6e3f8f62f419e5429a0bd89331c85c37824"
+  "lib/halmos-cheatcodes": {
+    "rev": "6da4e692c357ba6d641a2e677a28298cac9f76ab"
   },
   "lib/openzeppelin-contracts-upgradeable": {
     "tag": {
       "name": "v5.6.1",
       "rev": "7bf4727aacdbfaa0f36cbd664654d0c9e1dc52bf"
     }
   },
+  "lib/forge-std": {
+    "rev": "8bbcf6e3f8f62f419e5429a0bd89331c85c37824"
+  },
   "lib/openzeppelin-foundry-upgrades": {
     "tag": {
       "name": "v0.4.0",

script/deployment/DeployFlyover.s.sol

@@ -83,9 +83,10 @@ contract DeployFlyover is Script {
     /// @dev Reuses the same deployment and role wiring logic as run().
     function deployForTesting(
         address defaultAdmin,
-        HelperConfig.FlyoverConfig memory cfg
+        HelperConfig.FlyoverConfig memory cfg,
+        Options memory opts
     ) external returns (FlyoverDeployment memory d) {
-        d = _deployAll(defaultAdmin, cfg);
+        d = _deployAll(defaultAdmin, cfg, opts);
         _setupRoles(d);
     }
 

test/differential/base/DifferentialBase.sol

@@ -184,7 +184,8 @@ abstract contract DifferentialBase is Test {
         DeployFlyover deployer = new DeployFlyover();
         DeployFlyover.FlyoverDeployment memory d = deployer.deployForTesting(
             address(deployer),
-            cfg
+            cfg,
+            helper.getOptions()
         );
         targets.pegIn = d.pegInProxy;
         targets.pegOut = d.pegOutProxy;

test/discovery/Registration.t.sol

@@ -174,6 +174,9 @@ contract RegistrationTest is DiscoveryTestBase {
             Flyover.ProviderType.PegIn
         );
 
+        vm.prank(owner);
+        discovery.approveRegistration(lp);
+
         Flyover.LiquidityProvider memory p = discovery.getProvider(lp);
         assertEq(bytes(p.name).length, MAX_PROVIDER_NAME_LENGTH);
         assertEq(bytes(p.apiBaseUrl).length, MAX_PROVIDER_API_BASE_URL_LENGTH);

test/integration/FlyoverDiscovery.t.sol

@@ -624,12 +624,13 @@ contract FlyoverDiscoveryIntegrationTest is Test {
         assertEq(collateralManagement.getResignationBlock(lp), 0);
         assertEq(collateralManagement.getPegOutCollateral(lp), 0);
 
-        vm.prank(lp, lp);
-        uint reregisteredId = discovery.register{value: MIN_COLLATERAL}(
+        uint reregisteredId = _registerAndApprove(
+            lp,
             "PegOut Provider Again",
             "lp2.com",
             true,
-            Flyover.ProviderType.PegOut
+            Flyover.ProviderType.PegOut,
+            MIN_COLLATERAL
         );
 
         assertEq(reregisteredId, originalProviderId);