feature: suggested improviments

Author: gsoares85

internal/entities/wei_test.go

@@ -486,5 +486,52 @@ func TestWei_UnmarshalBSONValue(t *testing.T) {
 		assert.Equal(t, bson.TypeString, bsonTypeResult)
 		return bytes
 	})
+}
 
+func TestWei_Div(t *testing.T) {
+	tests := []struct {
+		name    string
+		w       *entities.Wei
+		x       *entities.Wei
+		y       *entities.Wei
+		want    *entities.Wei
+		wantErr bool
+	}{
+		{
+			name:    "divide two positive Wei values",
+			w:       entities.NewWei(0),
+			x:       entities.NewWei(10),
+			y:       entities.NewWei(5),
+			want:    entities.NewWei(2),
+			wantErr: false,
+		},
+		{
+			name:    "divide by zero",
+			w:       entities.NewWei(0),
+			x:       entities.NewWei(10),
+			y:       entities.NewWei(0),
+			want:    nil,
+			wantErr: true,
+		},
+		{
+			name:    "divide zero by a number",
+			w:       entities.NewWei(0),
+			x:       entities.NewWei(0),
+			y:       entities.NewWei(5),
+			want:    entities.NewWei(0),
+			wantErr: false,
+		},
+	}
+	for _, tt := range tests {
+		t.Run(tt.name, func(t *testing.T) {
+			got, err := tt.w.Div(tt.x, tt.y)
+			if (err != nil) != tt.wantErr {
+				t.Errorf("Div() error = %v, wantErr %v", err, tt.wantErr)
+				return
+			}
+			if !reflect.DeepEqual(got, tt.want) {
+				t.Errorf("Div() got = %v, want %v", got, tt.want)
+			}
+		})
+	}
 }

internal/usecases/pegin/get_pegin_report.go

@@ -88,9 +88,6 @@ func (useCase *GetPeginReportUseCase) Run(ctx context.Context) (GetPeginReportRe
 }
 
 func (useCase *GetPeginReportUseCase) calculateMinimumQuoteValue(quotes []quote.PeginQuote) *entities.Wei {
-	if len(quotes) == 0 {
-		return entities.NewWei(0)
-	}
 	minimum := quotes[0].Value
 
 	if len(quotes) > 1 {
@@ -105,9 +102,6 @@ func (useCase *GetPeginReportUseCase) calculateMinimumQuoteValue(quotes []quote.
 }
 
 func (useCase *GetPeginReportUseCase) calculateMaximumQuoteValue(quotes []quote.PeginQuote) *entities.Wei {
-	if len(quotes) == 0 {
-		return entities.NewWei(0)
-	}
 	maximum := quotes[0].Value
 
 	if len(quotes) > 1 {

internal/usecases/pegin/get_pegin_report_test.go

@@ -17,38 +17,51 @@ func TestGetPeginReportUseCase_Run(t *testing.T) {
 	retainedQuotes := []quote.RetainedPeginQuote{
 		{QuoteHash: "hash1"},
 		{QuoteHash: "hash2"},
+		{QuoteHash: "hash3"},
+		{QuoteHash: "hash4"},
+		{QuoteHash: "hash5"},
+		{QuoteHash: "hash6"},
+		{QuoteHash: "hash7"},
+		{QuoteHash: "hash8"},
+		{QuoteHash: "hash9"},
+		{QuoteHash: "hash10"},
 	}
 
 	peginQuotes := []quote.PeginQuote{
-		{
-			Value:   entities.NewWei(1000),
-			CallFee: entities.NewWei(10),
-		},
-		{
-			Value:   entities.NewWei(3000),
-			CallFee: entities.NewWei(20),
-		},
+		{Value: entities.NewWei(1000), CallFee: entities.NewWei(10)},
+		{Value: entities.NewWei(2000), CallFee: entities.NewWei(20)},
+		{Value: entities.NewWei(3000), CallFee: entities.NewWei(30)},
+		{Value: entities.NewWei(4000), CallFee: entities.NewWei(40)},
+		{Value: entities.NewWei(5000), CallFee: entities.NewWei(50)},
+		{Value: entities.NewWei(6000), CallFee: entities.NewWei(60)},
+		{Value: entities.NewWei(7000), CallFee: entities.NewWei(70)},
+		{Value: entities.NewWei(8000), CallFee: entities.NewWei(80)},
+		{Value: entities.NewWei(9000), CallFee: entities.NewWei(90)},
+		{Value: entities.NewWei(10000), CallFee: entities.NewWei(100)},
 	}
 
+	// Calculate expected values
 	expectedMinimumValue := entities.NewWei(1000)
-	expectedMaximumValue := entities.NewWei(3000)
-	expectedAverageValue := entities.NewWei((1000 + 3000) / 2)
-	expectedTotalFees := entities.NewWei(10 + 20)
-	expectedAverageFee := entities.NewWei((10 + 20) / 2)
+	expectedMaximumValue := entities.NewWei(10000)
+	expectedAverageValue := entities.NewWei(5500)
+	expectedTotalFees := entities.NewWei(550)
+	expectedAverageFee := entities.NewWei(55)
 
 	peginQuoteRepository := &mocks.PeginQuoteRepositoryMock{}
 	peginQuoteRepository.On("GetRetainedQuoteByState", ctx, quote.PeginStateRegisterPegInSucceeded).
 		Return(retainedQuotes, nil).Once()
-	peginQuoteRepository.On("GetQuote", ctx, "hash1").Return(&peginQuotes[0], nil).Once()
-	peginQuoteRepository.On("GetQuote", ctx, "hash2").Return(&peginQuotes[1], nil).Once()
+
+	for i, retainedQuote := range retainedQuotes {
+		peginQuoteRepository.On("GetQuote", ctx, retainedQuote.QuoteHash).Return(&peginQuotes[i], nil).Once()
+	}
 
 	useCase := pegin.NewGetPeginReportUseCase(peginQuoteRepository)
 
 	result, err := useCase.Run(ctx)
 
 	peginQuoteRepository.AssertExpectations(t)
 	require.NoError(t, err)
-	assert.Equal(t, 2, result.NumberOfQuotes)
+	assert.Equal(t, 10, result.NumberOfQuotes)
 	assert.Equal(t, expectedMinimumValue, result.MinimumQuoteValue)
 	assert.Equal(t, expectedMaximumValue, result.MaximumQuoteValue)
 	assert.Equal(t, expectedAverageValue, result.AverageQuoteValue)