feedback improvements [1]

Author: Dominikkq

internal/adapters/entrypoints/rest/common.go

@@ -30,21 +30,9 @@ func PositiveStringValidationRule(value string) bool {
 	return bigIntValue.Cmp(big.NewInt(0)) > 0
 }
 
-func ZeroOrPositiveStringValidationRule(value string) bool {
-	bigIntValue := new(big.Int)
-	bigIntValue.SetString(value, 10)
-	return bigIntValue.Cmp(big.NewInt(0)) >= 0
-}
-
-func NonNegativeStringValidationRule(value string) bool {
-	bigIntValue := new(big.Int)
-	bigIntValue.SetString(value, 10)
-	return bigIntValue.Cmp(big.NewInt(0)) >= 0
-}
-
 func percentageFeeValidator(fl validator.FieldLevel) bool {
 	val := fl.Field().Float()
-	if val < 0 || val > 100 {
+	if val < 0 || val >= 100 {
 		return false
 	}
 	valTimes100 := val * 100
@@ -67,19 +55,6 @@ func registerValidations() error {
 	if err := RequestValidator.RegisterValidation("percentage_fee", percentageFeeValidator); err != nil {
 		return fmt.Errorf("registering percentage_fee validation: %w", err)
 	}
-
-	if err := RequestValidator.RegisterValidation("non_negative_string", func(field validator.FieldLevel) bool {
-		return NonNegativeStringValidationRule(field.Field().String())
-	}); err != nil {
-		return fmt.Errorf("registering non_negative_string validation: %w", err)
-	}
-
-	if err := RequestValidator.RegisterValidation("zero_or_positive_string", func(field validator.FieldLevel) bool {
-		return ZeroOrPositiveStringValidationRule(field.Field().String())
-	}); err != nil {
-		return fmt.Errorf("registering zero_or_positive_string validation: %w", err)
-	}
-
 	return nil
 }
 

internal/entities/utils/encoding.go

@@ -30,19 +30,16 @@ func (bf *BigFloat) MarshalJSON() ([]byte, error) {
 	if bf == nil {
 		return []byte("null"), nil
 	}
-	valueStr := bf.Native().Text('f', -1)
-	return json.Marshal(valueStr)
+	value, _ := bf.Native().Float64()
+	return json.Marshal(value)
 }
 
 func (bf *BigFloat) UnmarshalJSON(b []byte) error {
-	var valueStr string
-	if err := json.Unmarshal(b, &valueStr); err != nil {
+	var value float64
+	if err := json.Unmarshal(b, &value); err != nil {
 		return err
 	}
-	_, ok := bf.Native().SetString(valueStr)
-	if !ok {
-		return fmt.Errorf("invalid BigFloat value: %s", valueStr)
-	}
+	bf.Native().SetFloat64(value)
 	return nil
 }
 

pkg/liquidity_provider.go

@@ -46,8 +46,8 @@ type PeginConfigurationDTO struct {
 	TimeForDeposit uint32  `json:"timeForDeposit" validate:"required"`
 	CallTime       uint32  `json:"callTime" validate:"required"`
 	PenaltyFee     string  `json:"penaltyFee" validate:"required,numeric,positive_string"`
-	FixedFee       string  `json:"fixedFee" validate:"required,numeric,zero_or_positive_string"`
-	FeePercentage  float64 `json:"feePercentage" validate:"numeric,percentage_fee,zero_or_positive_string"`
+	FixedFee       string  `json:"fixedFee" validate:"required,numeric,min=0"`
+	FeePercentage  float64 `json:"feePercentage" validate:"numeric,percentage_fee"`
 	MaxValue       string  `json:"maxValue" validate:"required,numeric,positive_string"`
 	MinValue       string  `json:"minValue" validate:"required,numeric,positive_string"`
 }
@@ -60,8 +60,8 @@ type PegoutConfigurationDTO struct {
 	TimeForDeposit       uint32  `json:"timeForDeposit" validate:"required"`
 	ExpireTime           uint32  `json:"expireTime" validate:"required"`
 	PenaltyFee           string  `json:"penaltyFee" validate:"required,numeric,positive_string"`
-	FixedFee             string  `json:"fixedFee" validate:"required,numeric,zero_or_positive_string"`
-	FeePercentage        float64 `json:"feePercentage" validate:"required,percentage_fee,zero_or_positive_string"`
+	FixedFee             string  `json:"fixedFee" validate:"required,numeric,min=0"`
+	FeePercentage        float64 `json:"feePercentage" validate:"required,percentage_fee"`
 	MaxValue             string  `json:"maxValue" validate:"required,numeric,positive_string"`
 	MinValue             string  `json:"minValue" validate:"required,numeric,positive_string"`
 	ExpireBlocks         uint64  `json:"expireBlocks" validate:"required"`