fix: percentageFee error messages | GBI-2642&GBI-2643 (#712)

* fix: percentageFee error messages | GBI-2642&GBI-2643

* fix: golang-cli

Author: Dominikkq

internal/adapters/entrypoints/rest/assets/static/configUtils.js

@@ -97,7 +97,13 @@ async function postConfig(sectionId, endpoint, config, csrfToken) {
             body: JSON.stringify({ configuration: config })
         });
         if (!response.ok) {
-            const errorData = await response.json();
+            const errorData = await response.json();            
+            if (errorData.details && typeof errorData.details === 'object') {
+                const detailMessages = Object.entries(errorData.details)
+                    .map(([field, message]) => `${field}: ${message}`)
+                    .join(', ');
+                throw new Error(detailMessages);
+            }
             throw new Error(`Error saving ${sectionId} configuration: ${errorData.message || 'Unknown error'}`);
         }
         return true;

internal/adapters/entrypoints/rest/assets/static/management.js

@@ -389,7 +389,7 @@ function checkFeeWarnings() {
     const existingToast = document.getElementById('warningToast');
     if (shouldWarn) {
         if (!existingToast) {
-            showWarningToast('It is recommended to enable at least one of "feePercentage" or "fixedFee".');
+            showWarningToast('You have configured a zero-fee setting. This means you won’t earn fees from bridging transactions.');
         } else {
             bootstrap.Toast.getOrCreateInstance(existingToast).show();
         }

internal/adapters/entrypoints/rest/common.go

@@ -134,6 +134,25 @@ func DecodeRequest[T any](w http.ResponseWriter, req *http.Request, body *T) err
 	return nil
 }
 
+func getValidationMessage(field validator.FieldError) string {
+	switch field.Tag() {
+	case "required":
+		return "is required"
+	case "numeric":
+		return "must be numeric"
+	case "positive_string":
+		return "must be a positive number"
+	case "gte":
+		return "must be greater than or equal to " + field.Param()
+	case "lte":
+		return "must be less than or equal to " + field.Param()
+	case "max_decimal_places":
+		return fmt.Sprintf("must have at most %s decimal places", field.Param())
+	default:
+		return "validation failed: " + field.Tag()
+	}
+}
+
 func ValidateRequest[T any](w http.ResponseWriter, body *T) error {
 	var validationErrors validator.ValidationErrors
 	err := RequestValidator.Struct(body)
@@ -145,7 +164,7 @@ func ValidateRequest[T any](w http.ResponseWriter, body *T) error {
 	}
 	details := make(ErrorDetails)
 	for _, field := range validationErrors {
-		details[field.Field()] = "validation failed: " + field.Tag()
+		details[field.Field()] = getValidationMessage(field)
 	}
 	jsonErr := NewErrorResponseWithDetails("validation error", details, true)
 	JsonErrorResponse(w, http.StatusBadRequest, jsonErr)

internal/adapters/entrypoints/rest/common_test.go

@@ -171,7 +171,7 @@ func TestValidateRequest(t *testing.T) {
 		assert.Contains(t, response.Message, "validation error")
 		assert.Len(t, response.Details, 2)
 		for key := range response.Details {
-			assert.Contains(t, response.Details[key], "validation failed")
+			assert.NotEmpty(t, response.Details[key])
 		}
 		assert.True(t, response.Recoverable)
 	})