Extracted getBlockTxIdsByTransactionHash so pmt-builder and pmt-witness-builder reuse that method

Author: julianlen

tool/pmt-builder-utils.js

@@ -91,4 +91,20 @@ const getTransactionWithRetry = async (transactionsClient, txId, retries = 0) =>
     }
 };
 
-module.exports = { getWtxids, sleep, getTransactionWithRetry, REQUEST_DELAY_MS };
+/**
+ * Fetches the transaction IDs (txids) of all transactions in the same block as the given transaction.
+ * @param {Object} blocksClient - The blocks client instance used to interact with the blockchain.
+ * @param {Object} transactionsClient - The transactions client instance used to interact with the blockchain.
+ * @param {string} txHash - The transaction hash for which to find the block's transaction IDs.
+ * @returns {Promise<string[]>} - A promise that resolves to an array of transaction IDs in the same block.
+ */
+
+const getBlockTxidsByTransactionHash = async (blocksClient, transactionsClient, txHash) => {
+    const transaction = await transactionsClient.getTx({ txid: txHash });
+    const blockHash = transaction.status.block_hash;
+    const blockTxids = await blocksClient.getBlockTxids({ hash: blockHash });
+
+    return blockTxids;
+};
+
+module.exports = { getWtxids, sleep, getTransactionWithRetry, getBlockTxidsByTransactionHash, REQUEST_DELAY_MS };

tool/pmt-builder.js

@@ -1,22 +1,17 @@
 const mempoolJS = require("@mempool/mempool.js");
 const pmtBuilder = require("../index");
+const { getBlockTxidsByTransactionHash } = require("./pmt-builder-utils");
 
 const getPmtInformation = async (network, txHash) => {
-
     const { bitcoin: { blocks, transactions } } = mempoolJS({
         hostname: 'mempool.space',
         network // 'testnet' | 'mainnet'
     });
 
-    const transaction = await transactions.getTx({ txid: txHash });
-    const blockHash = transaction.status.block_hash;
-
-    const blockTxids = await blocks.getBlockTxids({ hash: blockHash });
-
+    const blockTxids = await getBlockTxidsByTransactionHash(blocks, transactions, txHash);
     const resultPmt = pmtBuilder.buildPMT(blockTxids, txHash);
 
     return resultPmt;
-
 };
 
 (async () => {

tool/pmt-witness-builder.js

@@ -1,23 +1,17 @@
 const mempoolJS = require("@mempool/mempool.js");
 const pmtBuilder = require("../index");
-const { getWtxids } = require("./pmt-builder-utils");
+const { getWtxids, getBlockTxidsByTransactionHash } = require("./pmt-builder-utils");
 
 const getPmtInformationWithWitness = async (network, txHash) => {
-    const bitcoin = mempoolJS({
+    const { bitcoin: { blocks, transactions } } = mempoolJS({
         hostname: 'mempool.space',
         network // 'testnet' | 'mainnet'
     });
 
-    const transactionsClient = bitcoin.bitcoin.transactions;
-    const blocksClient = bitcoin.bitcoin.blocks;
-    
-    const transaction = await transactionsClient.getTx({ txid: txHash });
-
-    const blockHash = transaction.status.block_hash;
-    const blockTxIds = await blocksClient.getBlockTxids({ hash: blockHash });
-    
-    const { blockWtxids, targetWtxid } = await getWtxids(transactionsClient, blockTxIds, txHash);
+    const blockTxIds = await getBlockTxidsByTransactionHash(blocks, transactions, txHash);
+    const { blockWtxids, targetWtxid } = await getWtxids(transactions, blockTxIds, txHash);
     const resultPmt = pmtBuilder.buildPMT(blockWtxids, targetWtxid);
+
     return resultPmt;
 };