Enforce 100% coverage based on ENV, rather than script constant

Author: nevinera

.github/workflows/ci.yml

@@ -20,7 +20,7 @@ env:
   RSPEC_CI: true
   # This tells rspec-rails what branch to run in ci
   RSPEC_VERSION: '= 3.14.0.pre'
-  COVERAGE_ONLY_ON: "3.3"
+  ENFORCE_COVERAGE_AFTER: "3.1"
 jobs:
   rubocop:
     name: Rubocop

script/rspec_with_simplecov

@@ -24,18 +24,15 @@ begin
   # Simplecov emits some ruby warnings when loaded, so silence them.
   old_verbose, $VERBOSE = $VERBOSE, false
 
-  skip_because_no_coverage = ENV['NO_COVERAGE']
-  skip_because_wrong_version = ENV['COVERAGE_ONLY_ON'] && ENV['COVERAGE_ONLY_ON'].to_f != RUBY_VERSION.to_f
-
-  unless skip_because_no_coverage || skip_because_wrong_version
+  unless ENV['NO_COVERAGE'] || RUBY_VERSION.to_f < 2.1
     require 'simplecov'
 
     SimpleCov.start do
       root File.expand_path("../..", __FILE__)
       add_filter %r{/bundle/}
       add_filter %r{/tmp/}
       add_filter %r{/spec/}
-      minimum_coverage(100) if RUBY_VERSION.to_f >= 3.1
+      minimum_coverage(100) if RUBY_VERSION.to_f >= ENV['ENFORCE_COVERAGE_AFTER'].to_f
     end
   end
 rescue LoadError # rubocop:disable Lint/SuppressedException