Skip to content

Commit 7e1e98b

Browse files
authored
fix(shiny-preset): Empty nav links don't get padding (#1170)
* fix(shiny-preset): Empty nav links don't get padding * docs: Add NEWS item * Resave distributed files (GitHub Action)
1 parent 897dcb5 commit 7e1e98b

File tree

3 files changed

+4
-2
lines changed

3 files changed

+4
-2
lines changed

NEWS.md

+2
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,8 @@
2020

2121
* `input_switch()` and `input_dark_mode()` can be included in Shiny's [bookmarking feature](https://shiny.posit.co/r/articles/share/bookmarking-state/). (#1166)
2222

23+
* Fixed an issue with the Shiny preset (`bs_theme(5, "shiny")`) that caused a floating underling to appear when a `nav_panel_hidden()` was used and active. (#1170)
24+
2325
# bslib 0.8.0
2426

2527
## Breaking changes

inst/builtin/bs5/shiny/_rules.scss

+1-1
Original file line numberDiff line numberDiff line change
@@ -215,7 +215,7 @@ $bslib-checkbox-radio-margin-right: 0.35em !default;
215215
--#{$prefix}link-hover-color: rgba(var(--bs-body-color-rgb), 0.8);
216216
--#{$prefix}nav-link-font-size: 0.875rem;
217217

218-
.nav-link {
218+
.nav-link:not(:empty) {
219219
padding-left: 5px !important;
220220
padding-right: 5px !important;
221221

inst/css-precompiled/5/bootstrap.min.css

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)