submit to CRAN?

[timelyportfolio]

dygraphs on CRAN is missing all the fantastic changes by @pshevtsov since January 4, 2017. Would it be possible to submit an updated version to CRAN? Thanks.

[przmv]

Let me finish with #157 and then we're good to update. What do you think, @jjallaire ?

[jjallaire]

Sounds good! Let me know when #157 is ready to go.

[przmv]

Sure thing!

…

On Thu, May 18, 2017 at 4:38 PM JJ Allaire ***@***.***> wrote: Sounds good! Let me know when #157 <#157> is ready to go. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#164 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AARukzwpmeWxDd11BdcLxwObnmf-3oXBks5r7EnsgaJpZM4NfEJs> .

[timelyportfolio]

Happy to help @pshevtsov, so just let me know. Using dygraphs very extensively on a current project so very engaged.

[przmv]

@timelyportfolio could you please help me with #157?

[timelyportfolio]

@pshevtsov, sure what needs to be done? Happy to help.

[przmv]

@timelyportfolio, I want you to try dyArrow with different data sets and make sure everything works OK. I'm going to write some documentation on how to style popups with CSS later today.

[odelaigue]

@pshevtsov, I tested dyArrow with different data (different time step, regular or not).

It seems that it does not work when the data used in the dygraph function is a data.frame and not a ts or a xts object.

library(xts) data(sample_matrix) dygraph(sample_matrix) %>% dyArrow("2007-1-29", "test 1", direction = "down", fillColor = "red") %>% dyArrow("2007-2-1", "test 2", direction = "down", fillColor = "red")

When the date of the event does not exist in the dataset, there is no arrow, but also no warning.
And if I am right, it is the case in your example of the dyArrow function.

dygraph(presidents, main = "Quarterly Presidential Approval Ratings") %>% dyArrow("1950-6-30", "Korea", direction = "down", fillColor = "red") %>% dyArrow("1965-2-09", "Vietnam", direction = "down", fillColor = "red")

Another aspect is that the arrow is drawn on the last variable used (the last column fo example), maybe it will be usefull if it will be possible to give a name argument to choose more directly the curve.

lungDeaths <- cbind(fdeaths, mdeaths, ldeaths, foo = fdeaths/2, bar = fdeaths/3) dygraph(lungDeaths) %>% dyArrow("1977-6-01", "test 1", direction = "down", fillColor = "red") %>% dyArrow("1979-2-01", "test 2", direction = "down", fillColor = "red") %>% dyOptions(animatedZooms = TRUE)

[przmv]

Thanks @odelaigue, I'll have a look this weekend.

[thodoha]

Hi, can I check when will the updated version of dygraphs is submitted to CRAN? Or in other cases, how can I download the package from github?

[jjallaire]

You can install from GitHub with devtools::install_github("rstudio/dygraphs")

[jjallaire]

@pshevtsov Could you submit the version with all the recent changes to CRAN?

[klaukh]

Is it possible to take another look at #179 before CRAN? Requested changes were made and it's handy to define only a single color or single series color rather than the whole.

Also have been using extensively at project for awhile... it's awesome to pass a saved widget to another analyst that let's then explore rather than just a static view