Skip to content

Commit 87ae10f

Browse files
authored
Merge pull request #792 from rstudio/kegs-fix-connect-ci-check
Fix test script to use launcher.enabled and strict bash flags
2 parents 1097e34 + efd5df2 commit 87ae10f

File tree

6 files changed

+20
-9
lines changed

6 files changed

+20
-9
lines changed

.github/workflows/chart-test.yaml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -240,6 +240,9 @@ jobs:
240240
- name: Set up Helm
241241
uses: azure/setup-helm@v4
242242

243+
- name: Add rstudio helm repo
244+
run: helm repo add rstudio https://helm.rstudio.com
245+
243246
- uses: extractions/setup-just@v2
244247

245248
- name: Run executable verification for default interpreters

Justfile

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -88,31 +88,35 @@ test chart='all':
8888

8989
test-connect-interpreter-versions:
9090
#!/usr/bin/env bash
91-
set -xe
91+
set -euo pipefail
9292
cd ./charts/rstudio-connect && helm dependency build && cd -
9393

9494
# find the default image
9595
image=$(
9696
helm template ./charts/rstudio-connect \
97+
--set launcher.enabled=false \
9798
--show-only templates/deployment.yaml | \
9899
grep "image\:.*rstudio-connect.*" | \
99100
awk -F": " '{print $2}' | \
100101
xargs)
101102

102103
for lang in "Python" "Quarto" "R"
103104
do
105+
echo "Testing $lang"
106+
104107
# print the default connect config file for local execution in ini format
105108
# print the section and grep for the Executables to find each interpreter
106109
executables=$(
107110
helm template ./charts/rstudio-connect \
108-
--set config.Launcher.Enabled=false \
111+
--set launcher.enabled=false \
109112
--show-only templates/configmap.yaml | \
110113
sed -n -e "/\[$lang\]/,/\[*\]/ p" | \
111114
grep Executable | awk -F= '{print $2}' | \
112-
xargs)
115+
xargs || echo "")
113116

114117
for ex in $executables
115118
do
119+
echo "Checking $ex"
116120
docker run --rm $image /bin/bash -c "command -v $ex"
117121
done
118122
done

charts/rstudio-connect/Chart.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
name: rstudio-connect
22
description: Official Helm chart for Posit Connect
3-
version: 0.8.29
3+
version: 0.8.30
44
apiVersion: v2
55
appVersion: 2026.02.0
66
icon: https://raw.githubusercontent.com/rstudio/helm/main/images/posit-icon-fullcolor.svg

charts/rstudio-connect/NEWS.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,9 @@
11
# Changelog
22

3+
## 0.8.30
4+
5+
- Fix connect-version-check in CI
6+
37
## 0.8.29
48

59
- Re-enable TensorFlow serving and remove executable path from Connect configuration

charts/rstudio-connect/README.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
# Posit Connect
22

3-
![Version: 0.8.29](https://img.shields.io/badge/Version-0.8.29-informational?style=flat-square) ![AppVersion: 2026.02.0](https://img.shields.io/badge/AppVersion-2026.02.0-informational?style=flat-square)
3+
![Version: 0.8.30](https://img.shields.io/badge/Version-0.8.30-informational?style=flat-square) ![AppVersion: 2026.02.0](https://img.shields.io/badge/AppVersion-2026.02.0-informational?style=flat-square)
44

55
#### _Official Helm chart for Posit Connect_
66

@@ -30,11 +30,11 @@ To ensure reproducibility in your environment and insulate yourself from future
3030

3131
## Installing the chart
3232

33-
To install the chart with the release name `my-release` at version 0.8.29:
33+
To install the chart with the release name `my-release` at version 0.8.30:
3434

3535
```{.bash}
3636
helm repo add rstudio https://helm.rstudio.com
37-
helm upgrade --install my-release rstudio/rstudio-connect --version=0.8.29
37+
helm upgrade --install my-release rstudio/rstudio-connect --version=0.8.30
3838
```
3939

4040
To explore other chart versions, look at:

charts/rstudio-connect/values.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -438,13 +438,13 @@ config:
438438
# https://docs.posit.co/connect/admin/python/
439439
Executable:
440440
- /opt/python/3.12.11/bin/python
441-
- /opt/python/3.11.13/bin/python
441+
- /opt/python/3.13.9/bin/python
442442
Quarto:
443443
Enabled: true
444444
# Note: The `Executable` listed below is only used for Local Execution.
445445
# For Off-Host Execution, Quarto versions are defined by the set of Execution Environments
446446
# https://docs.posit.co/connect/admin/quarto/
447-
Executable: "/opt/quarto/1.4.557/bin/quarto"
447+
Executable: "/opt/quarto/1.8.25/bin/quarto"
448448
TensorFlow:
449449
Enabled: true
450450
# For off-host Execution, TensorFlow versions are defined by the set of Execution Environments https://docs.posit.co/connect/admin/tensorflow/

0 commit comments

Comments
 (0)