-
Notifications
You must be signed in to change notification settings - Fork 35
Open
Labels
enhancementNew feature or requestNew feature or requestteam: connectPosit Connect related issuePosit Connect related issue
Description
Description
Users would like the ability to add annotations to the deployment spec. Right now it's possible to add annotations to the pod spec and to the service spec, but not the deployment spec.
apiVersion: apps/v1
kind: Deployment
metadata:
annotations:
reloader.stakater.com/auto: "true"This request arose because I was talking to a user who is using a tool (https://github.com/stakater/Reloader) to automate redeployments when a secret changes. But that tool depends on an annotation being set on a deployment.
Approach
- Add new top level item to values.yaml:
deployment:
annotations: {}- Update the deployment template (https://github.com/rstudio/helm/blob/main/charts/rstudio-connect/templates/deployment.yaml) to add annotations set in values.yaml.
Other helm charts
If we would like to support this ability, we should add it to Workbench and Package Manager as well. I created an issue on Connect as a starting point to get the approach correct.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
enhancementNew feature or requestNew feature or requestteam: connectPosit Connect related issuePosit Connect related issue