Skip to content

Support for adding annotations to deployment spec to Package Manager #804

@SamEdwardes

Description

@SamEdwardes

Description

Users would like the ability to add annotations to the deployment spec. Right now it's possible to add annotations to the pod spec and to the service spec, but not the deployment spec.

apiVersion: apps/v1
kind: Deployment
metadata:
  annotations:
    reloader.stakater.com/auto: "true"

This request arose because I was talking to a user who is using a tool (https://github.com/stakater/Reloader) to automate redeployments when a secret changes. But that tool depends on an annotation being set on a deployment.

Approach

  • Add new top level item to values.yaml:
deployment:
    annotations: {}
  • Update the deployment template (https://github.com/rstudio/helm/blob/main/charts/rstudio-pm/templates/deployment.yaml) to add annotations set in values.yaml.

Related

I already completed this work for Connect. See, this pull request: #794

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions