Skip to content

Documentation on Error responses seems to be incorrect #66

Open
@atheriel

Description

@atheriel

The existing API documentation for Error responses has the following table:

Screenshot 2022-05-30 at 15-46-04 5 Launcher Plugin API RStudio Launcher Plugin Software Development Kit 1 0 21

However, in the actual source code the response ID for error messages seems to be hardcoded to zero:

Impl(Type in_responseType, uint64_t in_requestId) :
ResponseType(static_cast<int>(in_responseType)),
RequestId(in_requestId),
ResponseId(
((in_responseType == Type::HEARTBEAT) || (in_responseType == Type::ERROR)) ?
0 : NEXT_RESPONSE_ID.fetch_add(1))

Unless I'm reading this wrong, the docs should be updated to have 0 as the value of responseId instead of Int.

Metadata

Metadata

Assignees

No one assigned

    Labels

    launcherRelated to the launcher

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions