Fix: don't create .Random.seed as side effect of loading shiny (#4383)

Only call `httpuv::getRNGState()` when restoring a pre-existing
`.Random.seed`, avoiding RNG state creation when none existed before.

Fixes #4382

Author: gadenbuie

NEWS.md

@@ -28,6 +28,10 @@
   This method was never called by Shiny's runtime, so any overrides were dead
   code. Use `unsubscribe()` for cleanup logic instead. (#4375)
 
+## Bug fixes
+
+* Loading shiny no longer creates `.Random.seed` in the global environment as a side effect. (#4382)
+
 # shiny 1.13.0
 
 ## New features

R/utils.R

@@ -76,12 +76,12 @@ withPrivateSeed <- function(expr) {
 
     if (hasOrigSeed) {
       .GlobalEnv$.Random.seed <- origSeed
+      # Need to call this to make sure that the value of .Random.seed gets put
+      # into R's internal RNG state. (Issue #1763)
+      httpuv::getRNGState()
     } else {
       rm(.Random.seed, envir = .GlobalEnv, inherits = FALSE)
     }
-    # Need to call this to make sure that the value of .Random.seed gets put
-    # into R's internal RNG state. (Issue #1763)
-    httpuv::getRNGState()
   })
 
   expr