Skip to content

Commit e719d8a

Browse files
schloerkeschloerke
committed
Update cran-comments.md
1 parent c7116eb commit e719d8a

File tree

4 files changed

+105
-467
lines changed

4 files changed

+105
-467
lines changed

‎cran-comments.md‎

Lines changed: 77 additions & 69 deletions
Original file line numberDiff line numberDiff line change
@@ -1,121 +1,129 @@
11
## Comments
22

3-
#### 2025-12-01
3+
#### 2025-12-08
44

5-
Hi CRAN,
5+
Test has been removed from CRAN checks.
66

7-
We made changes to underlying structures that packages are not suppose to test. PRs were provided for each failing package.
7+
Also added a couple bug fixes as found by users.
88

9-
Maintainer change: From Winston Chang to Carson Sievert.
10-
11-
Please let me know if you need any further information.
9+
Please let me know if you need any further changes.
1210

1311
Thank you,
1412
Carson
1513

16-
## `R CMD check` results:
14+
#### 2025-12-04
1715

18-
The maintainer change is correctly detected. The URL check sometimes flags a 429
19-
error from Wikipedia, which is a temporary issue since the URL is valid when
20-
visited manually.
16+
Error:
2117

2218
```
23-
* checking CRAN incoming feasibility ... [19s] NOTE
24-
Maintainer: 'Carson Sievert <[email protected]>'
25-
26-
New maintainer:
27-
Carson Sievert <[email protected]>
28-
Old maintainer(s):
29-
Winston Chang <[email protected]>
30-
31-
Found the following (possibly) invalid URLs:
32-
URL: https://en.wikipedia.org/wiki/Reactive_programming
33-
From: README.md
34-
Status: 429
35-
Message: Too Many Requests
19+
Check Details
20+
Version: 1.12.0
21+
Check: tests
22+
Result: ERROR
23+
Running ‘testthat.R’ [100s/394s]
24+
Running the tests in ‘tests/testthat.R’ failed.
25+
Complete output:
26+
> library(testthat)
27+
> library(shiny)
28+
>
29+
> test_check("shiny")
30+
Saving _problems/test-timer-35.R
31+
[ FAIL 1 | WARN 0 | SKIP 22 | PASS 1981 ]
32+
33+
══ Skipped tests (22) ══════════════════════════════════════════════════════════
34+
• File system is not case-sensitive (1): 'test-app.R:36:5'
35+
• I'm not sure of a great way to test this without timers. (1):
36+
'test-test-server.R:216:3'
37+
• Not testing in CI (1): 'test-devmode.R:17:3'
38+
• On CRAN (18): 'test-actionButton.R:59:1', 'test-busy-indication.R:1:1',
39+
'test-busy-indication.R:15:1', 'test-busy-indication.R:50:1',
40+
'test-otel-error.R:1:1', 'test-otel-mock.R:1:1', 'test-pkgdown.R:3:3',
41+
'test-reactivity.r:146:1', 'test-reactivity.r:1240:5',
42+
'test-reactivity.r:1240:5', 'test-stacks-deep.R:93:1',
43+
'test-stacks-deep.R:141:1', 'test-stacks.R:140:3', 'test-tabPanel.R:46:1',
44+
'test-tabPanel.R:66:1', 'test-tabPanel.R:73:1', 'test-tabPanel.R:83:1',
45+
'test-utils.R:177:3'
46+
• {shinytest2} is not installed (1): 'test-test-shinyAppTemplate.R:2:1'
47+
48+
══ Failed tests ════════════════════════════════════════════════════════════════
49+
── Failure ('test-timer.R:35:3'): Unscheduling works ───────────────────────────
50+
Expected `timerCallbacks$.times` to be identical to `origTimes`.
51+
Differences:
52+
`attr(actual, 'row.names')` is an integer vector ()
53+
`attr(expected, 'row.names')` is a character vector ()
54+
55+
56+
[ FAIL 1 | WARN 0 | SKIP 22 | PASS 1981 ]
57+
Error:
58+
! Test failures.
59+
Execution halted
3660
```
3761

3862

39-
## Reverse dependency fixes
40-
41-
The revdep checks below are failing due to changes made in https://github.com/rstudio/shiny/pull/4249 .
42-
43-
Unresolved PRs submitted in 2025/06:
44-
* omicsTools - https://github.com/cheemalab/omicsTools/pull/1
45-
* shinyGovstyle - https://github.com/dfe-analytical-services/shinyGovstyle/pull/155
46-
* ShinyLink - https://github.com/cdc-addm/ShinyLink/pull/3
47-
* shinySbm - https://github.com/Jo-Theo/shinySbm/pull/2
63+
#### 2025-12-03
4864

49-
Unresolved PR submitted in 2025/10/29:
50-
* biodosetools - PR made 2025/10/29 - https://github.com/biodosetools-team/biodosetools/pull/64
51-
* inshiny - PR made 2025/10/29 - https://github.com/nicholasdavies/inshiny/pull/1
52-
53-
## Reverse dependency false positives
54-
55-
* SouthParkRshiny - New NOTE about installed package size. This is unrelated to any new changes in Shiny.
56-
57-
> ```
58-
> * checking installed package size ... NOTE
59-
> installed size is 8.6Mb
60-
> sub-directories of 1Mb or more:
61-
> data 8.0Mb
62-
> ```
65+
```
66+
Dear maintainer,
6367
64-
## revdepcheck results
68+
Please see the problems shown on
69+
<https://cran.r-project.org/web/checks/check_results_shiny.html>.
6570
66-
We checked 1395 reverse dependencies (1388 from CRAN + 7 from Bioconductor), comparing R CMD check results across CRAN and dev versions of this package.
71+
Please correct before 2025-12-17 to safely retain your package on CRAN.
6772
68-
* We saw 7 new problems
69-
* We failed to check 21 packages
73+
The CRAN Team
74+
```
7075

71-
Issues with CRAN packages are summarised below.
76+
## `R CMD check` results:
7277

73-
### New problems
74-
(This reports the first line of each new failure)
78+
0 errors | 0 warning | 1 note
7579

76-
* biodosetools
77-
checking tests ... ERROR
80+
```
81+
─ checking CRAN incoming feasibility ... [7s/70s] NOTE (1m 9.5s)
82+
Maintainer: ‘Carson Sievert <[email protected]>’
7883
79-
* inshiny
80-
checking examples ... ERROR
81-
checking tests ... ERROR
82-
checking re-building of vignette outputs ... ERROR
84+
Days since last update: 5
85+
```
8386

84-
* omicsTools
85-
checking tests ... ERROR
8687

87-
* shinyGovstyle
88-
checking tests ... ERROR
88+
## revdepcheck results
8989

90-
* ShinyLink
91-
checking tests ... ERROR
90+
We checked 1383 reverse dependencies (1376 from CRAN + 7 from Bioconductor), comparing R CMD check results across CRAN and dev versions of this package.
9291

93-
* shinySbm
94-
checking tests ... ERROR
92+
* We saw 0 new problems
93+
* We failed to check 31 packages
9594

96-
* SouthParkRshiny
97-
checking installed package size ... NOTE
95+
Issues with CRAN packages are summarised below.
9896

9997
### Failed to check
10098

99+
* AssumpSure
101100
* boinet
101+
* brms
102+
* cheem
102103
* ctsem
104+
* detourr
103105
* FAfA
104106
* fio
107+
* fitteR
105108
* FossilSimShiny
106109
* GDINA
107110
* ggsem
108111
* grandR
109112
* hbsaems
113+
* langevitour
110114
* lavaan.shiny
111115
* lcsm
112116
* linkspotter
113117
* loon.shiny
114118
* MOsemiind
115119
* MVN
120+
* pandemonium
121+
* polarisR
116122
* RCTrep
117123
* rstanarm
118124
* semdrw
125+
* shotGroups
119126
* sphereML
127+
* spinifex
120128
* SurprisalAnalysis
121129
* TestAnaAPP

‎revdep/README.md‎

Lines changed: 14 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -1,47 +1,45 @@
11
# Revdeps
22

3-
## Failed to check (28)
3+
## Failed to check (38)
44

55
|package |version |error |warning |note |
66
|:--------------------|:-------|:-----|:-------|:----|
77
|ADAMgui |? | | | |
8+
|AssumpSure |? | | | |
89
|boinet |1.5.0 |1 | | |
10+
|brms |? | | | |
11+
|cheem |? | | | |
912
|ctsem |3.10.4 |1 | |1 |
13+
|detourr |? | | | |
1014
|EMMAgeo |? | | | |
1115
|FactEff |? | | | |
1216
|FAfA |? | | | |
1317
|fio |0.1.6 |1 | | |
18+
|fitteR |? | | | |
1419
|FossilSimShiny |? | | | |
1520
|GDINA |? | | | |
1621
|ggsem |? | | | |
1722
|grandR |? | | | |
1823
|GSVA |? | | | |
19-
|hbsaems |0.1.1 |1 | | |
24+
|hbsaems |? | | | |
25+
|langevitour |? | | | |
2026
|lavaan.shiny |? | | | |
2127
|lcsm |? | | | |
22-
|linkspotter |1.3.0 |1 | | |
28+
|linkspotter |? | | | |
2329
|loon.shiny |? | | | |
2430
|MOsemiind |0.1.0 |1 | | |
25-
|MVN |6.2 |1 | | |
31+
|MVN |? | | | |
32+
|pandemonium |? | | | |
33+
|polarisR |? | | | |
2634
|Prostar |? | | | |
2735
|RCTrep |1.2.0 |1 | | |
2836
|recmap |? | | | |
2937
|rstanarm |2.32.2 |1 | | |
3038
|semdrw |? | | | |
39+
|shotGroups |? | | | |
3140
|sphereML |? | | | |
41+
|spinifex |? | | | |
3242
|StatTeacherAssistant |? | | | |
3343
|SurprisalAnalysis |? | | | |
3444
|TestAnaAPP |? | | | |
3545

36-
## New problems (7)
37-
38-
|package |version |error |warning |note |
39-
|:---------------|:-------|:------|:-------|:--------|
40-
|[biodosetools](problems.md#biodosetools)|3.7.1 |__+1__ | | |
41-
|[inshiny](problems.md#inshiny)|0.1.0 |__+3__ | | |
42-
|[omicsTools](problems.md#omicstools)|1.0.5 |__+1__ | | |
43-
|[shinyGovstyle](problems.md#shinygovstyle)|0.1.0 |__+1__ | | |
44-
|[ShinyLink](problems.md#shinylink)|0.2.2 |__+1__ | | |
45-
|[shinySbm](problems.md#shinysbm)|0.1.5 |__+1__ | |1 |
46-
|[SouthParkRshiny](problems.md#southparkrshiny)|1.0.0 | | |1 __+1__ |
47-

‎revdep/cran.md‎

Lines changed: 13 additions & 29 deletions
Original file line numberDiff line numberDiff line change
@@ -1,58 +1,42 @@
11
## revdepcheck results
22

3-
We checked 1395 reverse dependencies (1388 from CRAN + 7 from Bioconductor), comparing R CMD check results across CRAN and dev versions of this package.
3+
We checked 1383 reverse dependencies (1376 from CRAN + 7 from Bioconductor), comparing R CMD check results across CRAN and dev versions of this package.
44

5-
* We saw 7 new problems
6-
* We failed to check 21 packages
5+
* We saw 0 new problems
6+
* We failed to check 31 packages
77

88
Issues with CRAN packages are summarised below.
99

10-
### New problems
11-
(This reports the first line of each new failure)
12-
13-
* biodosetools
14-
checking tests ... ERROR
15-
16-
* inshiny
17-
checking examples ... ERROR
18-
checking tests ... ERROR
19-
checking re-building of vignette outputs ... ERROR
20-
21-
* omicsTools
22-
checking tests ... ERROR
23-
24-
* shinyGovstyle
25-
checking tests ... ERROR
26-
27-
* ShinyLink
28-
checking tests ... ERROR
29-
30-
* shinySbm
31-
checking tests ... ERROR
32-
33-
* SouthParkRshiny
34-
checking installed package size ... NOTE
35-
3610
### Failed to check
3711

12+
* AssumpSure (NA)
3813
* boinet (NA)
14+
* brms (NA)
15+
* cheem (NA)
3916
* ctsem (NA)
17+
* detourr (NA)
4018
* FAfA (NA)
4119
* fio (NA)
20+
* fitteR (NA)
4221
* FossilSimShiny (NA)
4322
* GDINA (NA)
4423
* ggsem (NA)
4524
* grandR (NA)
4625
* hbsaems (NA)
26+
* langevitour (NA)
4727
* lavaan.shiny (NA)
4828
* lcsm (NA)
4929
* linkspotter (NA)
5030
* loon.shiny (NA)
5131
* MOsemiind (NA)
5232
* MVN (NA)
33+
* pandemonium (NA)
34+
* polarisR (NA)
5335
* RCTrep (NA)
5436
* rstanarm (NA)
5537
* semdrw (NA)
38+
* shotGroups (NA)
5639
* sphereML (NA)
40+
* spinifex (NA)
5741
* SurprisalAnalysis (NA)
5842
* TestAnaAPP (NA)

0 commit comments

Comments
 (0)